877571 - Music player does not recognize audio/mp4a-latm mime type

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[mayayo]

Attachment: 1369670138847.m4a

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20130527 Firefox/24.0 (Nightly/Aurora)
Build ID: 20130527031027

Steps to reproduce:

Mime type for audio files is audio/mp4a-latm.
Trying to play audio file from Music app directly and through open activity.
Audio sample file attached. 


Actual results:

When trying to play file from Music app, error received is:
MediaDB: error parsing metadata for 1369670138847.m4a : Unknown MP4 file type

Seems the following check fails:

if (magic.substring(8, 12) in MP4Types) {

https://github.com/mozilla-b2g/gaia/blob/master/apps/music/js/metadata.js#L126


Expected results:

Music player should support MP4 files. 

Filing bug as per Sotaro Ikeda's advice.

Comment 1

[Marco Chen [:mchen]]

The major brand in this file is "isom" and compatible is isom & 3gp4. Currently Gaia didn't recognize one of them as MP4. 

Hi Dominic,

Maybe you can help this issue or know someone can help. Thanks.

Comment 2

[Dominic Kuo [:dkuo]]

Marco, I can give a patch on this, and do you know all the MP4 types we currenly supported? probably we can fix all MP4 type issues together in one bug.

Comment 3

[Marco Chen [:mchen]]

Please refer to the link as below for all possible format
http://www.ftyps.com/
And there is a bug 868333 for finding out the right way to filter mp4.
But it seems to be pending there.

I think at least gaia can sync the signatures with Gecko then wait for bug 868333.
You can refer to the patch from bug 859711 for current signatures used by Gecko which covered issue here.

Comment 4

[Dominic Kuo [:dkuo]]

Fixed by bug 882099.