Closed
Bug 877599
Opened 12 years ago
Closed 12 years ago
Remove unused precedence field from JSCodeSpec
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jandem, Assigned: Benjamin)
Details
Attachments
(1 file)
|
52.17 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
JSCodeSpec::prec appears to be unused, so we can remove it + the prec "column" in jsopcode.tbl
|
Assignee | |
Comment 1•12 years ago
|
||
Here we go. The only space saved is mental due to alignment, but who's complaining. I also left the precedence table in jsopcode.tbl because it seemed possibly useful.
Assignee: general → benjamin
Attachment #756035 -
Flags: review?(luke)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 756035 [details] [diff] [review]
remove prec
Hopefully can get reviewed before its rotted more. :)
Attachment #756035 -
Flags: review?(luke) → review?(jorendorff)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 756035 [details] [diff] [review]
remove prec
Review of attachment 756035 [details] [diff] [review]:
-----------------------------------------------------------------
Yay.
The nice precedence table could be moved to Parser.h or .cpp, if you wanted to.
(There's an array called PrecedenceTable in Parser.cpp that contains a subset of this information...)
Attachment #756035 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•