Make "Select time/date" picker in the System app more test friendly

NEW
Unassigned

Status

Firefox OS
Gaia::System
5 years ago
3 years ago

People

(Reporter: AlinT, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 755871 [details]
Screenshot of the html

Calendar app -> New event -> Start time -> Select time popup

The issue is we don't currently have and ID or a class property for the highlighted values in "Select time" popup.
Without an ID or a class property, testing that part of gaia is really tricky and time consuming.
Can you please add "selected", "current" or whatever you think is more suitable here? Thanks.
(Reporter)

Updated

5 years ago
OS: Linux → All
Hardware: x86_64 → All
James, something you could help us with?
Flags: needinfo?(jlal)
I believe this is going to end up as a bug for the System application. System listens for focus events on certain types of input elements and creates the specialized input UI:

https://github.com/mozilla-b2g/gaia/blob/2d870100a945272824f8e42a8c52aac095fe907e/apps/system/js/value_selector/value_selector.js#L26-L75
As mike stated this is part of the system app... We have plans https://github.com/mozilla-b2g/marionette-plugin-forms to abstract this for the js tests so individual tests don't need to be aware of our implementation details.

needinfo'ing Rudy who worked on most of the pieces here at one point.
Flags: needinfo?(jlal) → needinfo?(rlu)
Sorry that I might not get the point here.

Is this testing about system value selector, especially the time picker or about the calendar app?

If this is for Calendar app and we want abstract the time picker part out, I think we can regard that "time" input field as a general text input, and we can set value to it directly.
Flags: needinfo?(rlu)

Comment 5

4 years ago
Rudy I've re-titled the bug. Alin definitely means "System" level.
Summary: Make "Select time" popup, in Calendar app, more test friendly → Make "Select time/date" picker in the System app more test friendly

Updated

4 years ago
Whiteboard: [xfail]
Alive - Could you look into this? We need help getting this fixed to get the two tests mentioned below turned back on in gaia ui test automation.

- test_calendar_new_event_appears_on_all_calendar_views
- test_select_album_play
Flags: needinfo?(alive)
I think Rudy is familiar than me in this part.
Flags: needinfo?(alive)

Updated

4 years ago
Blocks: 931962
Rudy, can you take another look at this one?
Flags: needinfo?(rlu)
Sure, I am going to look into this.
However, right now I am also loaded with some koi+ bugs, so won't get into this right now.

Please feel free to take it if anyone is interested.
Flags: needinfo?(rlu)

Updated

4 years ago
Whiteboard: [xfail]
You need to log in before you can comment on or make changes to this bug.