877611 - Make "Select time/date" picker in the System app more test friendly

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Trif Andrei-Alin[:AlinT]]

Attachment: Screenshot of the html

Calendar app -> New event -> Start time -> Select time popup

The issue is we don't currently have and ID or a class property for the highlighted values in "Select time" popup.
Without an ID or a class property, testing that part of gaia is really tricky and time consuming.
Can you please add "selected", "current" or whatever you think is more suitable here? Thanks.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

James, something you could help us with?

Comment 2

[Mike Pennisi [:jugglinmike]]

I believe this is going to end up as a bug for the System application. System listens for focus events on certain types of input elements and creates the specialized input UI:

https://github.com/mozilla-b2g/gaia/blob/2d870100a945272824f8e42a8c52aac095fe907e/apps/system/js/value_selector/value_selector.js#L26-L75

Comment 3

[James Lal [:lightsofapollo]]

As mike stated this is part of the system app... We have plans https://github.com/mozilla-b2g/marionette-plugin-forms to abstract this for the js tests so individual tests don't need to be aware of our implementation details.

needinfo'ing Rudy who worked on most of the pieces here at one point.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sorry that I might not get the point here.

Is this testing about system value selector, especially the time picker or about the calendar app?

If this is for Calendar app and we want abstract the time picker part out, I think we can regard that "time" input field as a general text input, and we can set value to it directly.

Comment 5

[Zac C (:zac)]

Rudy I've re-titled the bug. Alin definitely means "System" level.

Comment 6

[Jason Smith [:jsmith]]

Alive - Could you look into this? We need help getting this fixed to get the two tests mentioned below turned back on in gaia ui test automation.

- test_calendar_new_event_appears_on_all_calendar_views
- test_select_album_play

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

I think Rudy is familiar than me in this part.

Comment 8

[Dylan Oliver [:doliver]]

Rudy, can you take another look at this one?

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sure, I am going to look into this.
However, right now I am also loaded with some koi+ bugs, so won't get into this right now.

Please feel free to take it if anyone is interested.

Comment 10

[BMO Automation]

Firefox OS is not being worked on