877615 - [MMS] New message composer: Recipients field stays expanded after discarding a previous multi recipient message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: shows the bug issue

- Add a lot of recipients in 'new' screen of MMS/SMS App
- Tap on 'back' and cancel the SMS
- Go again to 'new'

EXPECTED:
Recipients container height is reset, so the form is started from the scratch

CURRENTLY:
Recipients container height is the previous one, so the layout is broken.

Comment 1

[Dylan Oliver [:doliver]]

triage: leo+ -- doesn't seem uncommon that you'd add a second person then change your mind. we don't want to lose the screen real estate for that.

Comment 2

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10151

Pointer to Github pull-request

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 757198 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10151

Set the visible style to "singleline" when go into New message view.

Steve,
Could you please help to review my pr? Thanks.

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 757198 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10151

We should reset the recipient height to single height while init, so r=me.

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 757198 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10151

Sorry, the test case does not pass... Please fix the unit test for this patch, thanks.

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 757198 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10151

Add unitest mock method for visible(). Looks like no failed message relative with SMS. Please help to review the pr again. Thank you.

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 757198 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10151

Thanks for fixing the test case, r=me.

Comment 8

[[e-mail], [e-mail]]

Thanks for Steve's reviewing effort. We can close the issue now since the pr is merged.

master:   61440e3abaf2d94aa4146c9638ec9f99ab19be3e
v1-train: 66e1cf33f595176b1154378934e31fc56fc28bfd

Comment 9

[Rick Waldron [:rwaldron]]

This should've included tests.

Comment 10

[Rick Waldron [:rwaldron]]

Attachment: Tests for 877615

Comment 11

[Corey Frang [:gnarf]]

Comment on attachment 758033 [details] [review]
Tests for 877615

r=me

Comment 12

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/59ee4a159e2e313b736de4ea10e30049d4d93d40

Comment 13

[Corey Frang [:gnarf]]

master: 59ee4a159e2e313b736de4ea10e30049d4d93d40
v1-train: c5f3a52eb1e49de2a453e84c2c3a017f0a845d6a

Comment 14

[:CSchmoeckel]

Added MMS Suite Test Case #8573 [Messages] Creating a new message resets the Message App's recipient container

Comment 15

[Deepa Subramanian]

The container height and UI layout is set to normal when the user tries to compose a message on the SMS app.

Verified on
Leo Build ID: 20130610070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0