Closed Bug 877627 Opened 8 years ago Closed 8 years ago

[Contacts][Dialer] Dialer doesn't show on screen when launching from contacts


(Firefox OS Graveyard :: General, defect)

Gonk (Firefox OS)
Not set


(blocking-b2g:tef+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 verified, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 verified, b2g-v1.1hd fixed)

1.0.1 IOT3 (3jun)
blocking-b2g tef+
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- verified
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- verified
b2g-v1.1hd --- fixed


(Reporter: askeing, Assigned: airpingu)



(Keywords: regression)


(2 files, 3 obsolete files)


## STR:
0. Prepare a contact with phone number in Contacts app.
1. Restart the device.
2. Open Contacts app.
3. Select on contact, open the detail page.
4. Click the phone number field to launch the dialer.
5. After the phone call success, ring off it.
6. Click the phone number field to launch dialer again.

## Expected:
The dialer should be displayed on the screen.

## Actual:
No dialer on the screen.
The phone call run on background, so user can not ring off.
blocking-b2g: --- → tef?
It looks like a Gaia bug?
Barker, can Qanalyst take a look at this and try and reproduce on the Inari 1.0.1 latest build?   if it works, then flash the latest Partner build and try again.  Report the results back here.   Thanks
This is a dupe of the dialer issue.
Cellular and Data is not working on leo devices -
This issue is reproducing on the latest v1.0.1 build as well as the latest partner build. Dialer does not show up on screen when launched the second time. The call still goes through to the other device tho but there is no way to hangup. The only way to end the call is by restarting the device.  

Inari, Build ID: 20130530070213
Gaia: ac293ce59acc3bede083fad1b973794fa8bf0253

Inari, Build ID: 20130530053909
Gecko: /rev/
Gaia: 3fe8fac22cf096addb39ba633bd51293be3ebb05

Issue reproduces on v1.1 as well

Unagi, Build ID: 20130529070208
Gaia: 8f5ab7bfd4a2921aab4e2de11e0d79a29c1bb062
(In reply to Allen Maxwell from comment #3)
> This is a dupe of the dialer issue.
> Cellular and Data is not working on leo devices -

different device and different builds.  could be gonk related, so lets track them separate for now.
Attached file logcat

Just for clarification, this has not been reproduced with ikura iot#3 build, w/ commercial RIL. I've tried several times, and not able to reproduce it. 

Buildid: 20130528231041

I think you are testing with a later build, maybe a regression on May 30th build?

I was able to reproduce this with the 20130528231041 partner build. Using 4 different SIM cards. 

Inari, Build ID: 20130528231041
Gecko: /rev/
Gaia: 6d1008a5f7b4509dd84eca47d036bc65c462714a
Parter build 20130530
Gaia:     fb8777fc8325a383f20ec88341e72e943d9b4028
BuildID   20130530054624
Version   18.0

Can reprduce.

BTW, if open Dialer app before launch Contacts app, it works fine.
Ikura 20130530053909 MOVISTAR build(v101)
Unagi 20130530070213 PVT V101 build

I can reproduce it.

I think it might have something wrong in contact app, too.
If I dial the contact in contacts app, hang up it, kill contacts app, and reopen contacts app, the app would be white.
Yeah, I can reproduce it on latest Gecko and Gaia, as for right now.
Is there anyone looking at this bug? Thanks!
Flags: needinfo? , you should try to tell us more about your build info.
Information like gecko branch, gecko version, gaia branch, gaia version, and device information would help a lot.
Flags: needinfo?
I'll try to look into this from the Gecko side. However, it looks like a Gaia issue to me because it's working well after the Contacts app is killed.

We also need Gaia folks' support at the same time.
Gene is checking gecko part and Tim is checking Gaia part.
blocking-b2g: tef? → tef+
I can also reproduce this issue with my Ikura.
Keywords: regression
Regression window: 5/22-5/23 unagi pvt build
Not gaia issue because all gaia revision during that time works with 5/22 pvt build.
change component to general as it seems like gecko bug
Component: Gaia::Contacts → General
Component: Gaia::Contacts → General
Seems Gecko, I've tested very old Gaia versions on top of today's Gecko and the failure can be reproduced
Assignee: nobody → gene.lian
Dialer app didn't receive system message when it is opened.
If we manually kill dialer app every time when a call end, the problem won't occurs.
:evelyn if that's true the dialer couldn't make two calls as well no?
Alberto is pointing to me to the old bug 818623. It seems a workaround was done in Gaia in that bug but it is not working due to the latest Gecko changes. Gene, can you confirm this just requires a fix in Gecko?
Flags: needinfo?(gene.lian)
Yes, I'm working on this and will try to fix ASAP.
Flags: needinfo?(gene.lian)
batch update on tef+ milestones. partner to make a final on 6/3 Asia time. TEF+ needs to be resolved by 6/3 to be in the final build. thanks
Target Milestone: --- → 1.0.1 IOT3 (3jun)
Attached patch Patch (obsolete) — Splinter Review
Attachment #756527 - Flags: review?(mounir)
Attachment #756527 - Flags: review?(fabrice)
Comment on attachment 756527 [details] [diff] [review]

Review of attachment 756527 [details] [diff] [review]:

Fabrice should do the review.
Attachment #756527 - Flags: review?(mounir)
Attached patch Patch, V2 (obsolete) — Splinter Review
Attachment #756527 - Attachment is obsolete: true
Attachment #756527 - Flags: review?(fabrice)
Attachment #756548 - Flags: review?(swu)
Attachment #756548 - Flags: review?(mounir)
Attachment #756548 - Flags: review?(fabrice)
Attachment #756548 - Flags: review?(mounir)
Attached patch Patch, V2.1 (obsolete) — Splinter Review
Attachment #756548 - Attachment is obsolete: true
Attachment #756548 - Flags: review?(swu)
Attachment #756548 - Flags: review?(fabrice)
Attachment #756553 - Flags: review?(swu)
Attachment #756553 - Flags: review?(fabrice)
Comment on attachment 756553 [details] [diff] [review]
Patch, V2.1

Review of attachment 756553 [details] [diff] [review]:

Per discussion with Gene on the design logic, the code looks good to me.
Attachment #756553 - Flags: review?(swu) → review+
Comment on attachment 756548 [details] [diff] [review]
Patch, V2

Review of attachment 756548 [details] [diff] [review]:

r=me with nits fixed.

::: dom/messages/SystemMessageInternal.js
@@ +249,5 @@
> +    }
> +    return true;
> +  },
> +
> +  _removeTargetFromListener: function _removeTargetFromListener(aTarget, aManifest, aRemoveListener, aUri) {

nit: is this < 80 characters?

@@ +314,3 @@
>          let targets, index;
>          if (!(targets = this._listeners[msg.manifest])) {
> +          let winCounts = {}; winCounts[uri] = 1;

nit: winCounts[uri] = 1; on its own line, or do:
let winCounts = { uri: 1 };

@@ +319,2 @@
>          } else if ((index = this._findTargetIndex(targets, === -1) {
> +          let winCounts = {}; winCounts[uri] = 1;

Attachment #756548 - Attachment is obsolete: false
Attached patch Patch, V2.2Splinter Review
Attachment #756548 - Attachment is obsolete: true
Attachment #756553 - Attachment is obsolete: true
Attachment #756553 - Flags: review?(fabrice)
Attachment #756562 - Flags: review+
Birch and inbound are closed now so I cannot land this. Since this is a super urgent issue, land b2g18_v1_0_1 first.
Angela or askeing, please verify this is fixed on next day's 1.0.1 and 1.1 build.  thanks.
Flags: needinfo?(fyen)
Flags: needinfo?(ahubenya)
Keywords: verifyme
Closed: 8 years ago
Resolution: --- → FIXED
Unagi, 20130531 PVT 1.0.1
  Gaia:     e7114bdf4078274fc127a3b2a58dad91d6884219
  BuildID   20130531070208
  Version   18.0
does not contain

Unagi, 20130531 PVT v1-train
  Gaia:     e1c59baed29e4665d1da9392f86239272073f07a
  BuildID   20130531070205
  Version   18.0
does not contain

Create the local build to verify first, and wait the next PVT build.

Unagi, v1.0.1 local build works fine.
    Gaia mozillaorg/v1.0.1 - f13d8be2ff848bae3d72cd83a69abea5e3572311
    Gecko mozillaorg/v1.0.1 - 3b5f918b2c43ddebc0458457a2f127775b96cead
Flags: needinfo?(fyen)
Depends on: 878395
The solution here is still not really complete. Fire a follow-up by Bug 878395.

Fortunately, the current logic is still safe (please see bug 878395, comment #0).
I think it is safe as far as I tested it in Unagi PVT V1Train 20130531230204.
Ikura 20130601 MOVISTAR is good to go.
Set to verified fixed as for now.
Keywords: verifyme
Just for the records, although this issue is solved and verified, it's safer to include the follow-up patch at bug 878395 no matter for the PTV or vendor's testing build. These two patches should be considered as set.
s/set/a set/
Issue is verified as fixed on the latest v1 and v1.0.1 builds. I was able to make calls with the dealer appearing on screen every single time, by repeating the steps in the video of comment 7.

Unagi, Build ID: 20130603070207
Gaia: 4de4354e3a99f151a834743c7b03a041ac8db12f

Inari, Build ID: 20130603070208
Gaia: fcae23654296c9cc645c2b7e77a2c36bf494803a
Flags: needinfo?(ahubenya)
You need to log in before you can comment on or make changes to this bug.