877714 - Take a code walk along the API search/featured path

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, defect, P2)

Description

[Rob Hudson [:robhudson]]

Look for things we can optimize or cache.

Comment 1

[Andy McKay]

I split out apps.search and apps.featured in graphite so we can see stats. apps.search has gotten faster, showing that apps.featured is the hog.

Comment 2

[Andy McKay]

There are two main areas of interest:

https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L172
https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L175

With 1 featured app we get:

line 172: 86ms
line 175: 35ms

With 20 featured apps we get:

line 172: 321ms
line 175: 307ms

Comment 3

[Andy McKay]

Cleaned up the first of those so its less O(n):

https://github.com/mozilla/zamboni/commit/30b8ca

Would like to take a look at the app dehydrate next.

Comment 4

[Andy McKay]

It's still slow though:

http://graphite1.dmz.phx1.mozilla.com/render/?width=586&height=308&_salt=1372463252.025&target=stats.timers.marketplace-dev.api.fireplace.featured.GET.upper_90&from=00%3A00_20130607&until=23%3A59_20130628

Comment 5

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/94b8704 added caching to one of the lower featured calls that is doing a complex SQL query.

Comment 6

[Mathieu Pillard [:mat]]

We did some of that a while ago in other bugs, but the API endpoint is going away anyway because of the feed.