Take a code walk along the API search/featured path

RESOLVED WONTFIX

Status

Marketplace
Code Quality
P2
normal
RESOLVED WONTFIX
5 years ago
3 years ago

People

(Reporter: robhudson, Unassigned)

Tracking

x86
Mac OS X
Points:
---

Details

(Whiteboard: p=2)

(Reporter)

Description

5 years ago
Look for things we can optimize or cache.

Updated

5 years ago
Priority: -- → P2
Whiteboard: p=2

Updated

5 years ago
Assignee: nobody → amckay
Target Milestone: --- → 2013-06-27

Comment 1

5 years ago
I split out apps.search and apps.featured in graphite so we can see stats. apps.search has gotten faster, showing that apps.featured is the hog.

Comment 2

5 years ago
There are two main areas of interest:

https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L172
https://github.com/mozilla/zamboni/blob/master/mkt/search/api.py#L175

With 1 featured app we get:

line 172: 86ms
line 175: 35ms

With 20 featured apps we get:

line 172: 321ms
line 175: 307ms

Comment 3

5 years ago
Cleaned up the first of those so its less O(n):

https://github.com/mozilla/zamboni/commit/30b8ca

Would like to take a look at the app dehydrate next.
Target Milestone: 2013-06-27 → 2013-07-04

Updated

5 years ago
Assignee: amckay → nobody
Target Milestone: 2013-07-04 → 2013-07-11
(Reporter)

Comment 5

5 years ago
https://github.com/mozilla/zamboni/commit/94b8704 added caching to one of the lower featured calls that is doing a complex SQL query.

Updated

4 years ago
Target Milestone: 2013-07-11 → ---
We did some of that a while ago in other bugs, but the API endpoint is going away anyway because of the feed.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.