877719 - DebuggerServer.destroy should always work

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

... even if there are outstanding connections.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 756032 [details] [diff] [review]
v1

Review of attachment 756032 [details] [diff] [review]:
-----------------------------------------------------------------

I think that's how I had implemented it initially, but IIANM it was interfering with how Marionette used the debugger server. jgriffin should know if it will affect them.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 756032 [details] [diff] [review]
v1

Review of attachment 756032 [details] [diff] [review]:
-----------------------------------------------------------------

This seems ok.  The previous problem we had was that whenever a consumer closed a socket, the server would shut down the listener, which broke Marionette.  This patch doesn't do that.

Comment 3

[Dave Camp (:dcamp)]

Landed this but backed it out.  Looks like bug 878292 was to blame, try with both fixes here:

https://tbpl.mozilla.org/?tree=Try&rev=44f0f69b4217

Comment 4

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/27ab9f0a22f6

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/27ab9f0a22f6