Closed Bug 877719 Opened 9 years ago Closed 9 years ago

DebuggerServer.destroy should always work

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: dcamp, Unassigned)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
... even if there are outstanding connections.
Attachment #756032 - Flags: review?(past)
Comment on attachment 756032 [details] [diff] [review]
v1

Review of attachment 756032 [details] [diff] [review]:
-----------------------------------------------------------------

I think that's how I had implemented it initially, but IIANM it was interfering with how Marionette used the debugger server. jgriffin should know if it will affect them.
Attachment #756032 - Flags: review?(past)
Attachment #756032 - Flags: review+
Attachment #756032 - Flags: feedback?(jgriffin)
Comment on attachment 756032 [details] [diff] [review]
v1

Review of attachment 756032 [details] [diff] [review]:
-----------------------------------------------------------------

This seems ok.  The previous problem we had was that whenever a consumer closed a socket, the server would shut down the listener, which broke Marionette.  This patch doesn't do that.
Attachment #756032 - Flags: feedback?(jgriffin) → feedback+
Landed this but backed it out.  Looks like bug 878292 was to blame, try with both fixes here:

https://tbpl.mozilla.org/?tree=Try&rev=44f0f69b4217
https://hg.mozilla.org/mozilla-central/rev/27ab9f0a22f6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Depends on: 881101
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.