Closed Bug 877774 Opened 8 years ago Closed 7 years ago

Reader Mode tweaks for Clear Sans

Categories

(Firefox for Android :: Reader View, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 27

People

(Reporter: ibarlow, Assigned: nickecarlo)

References

Details

(Whiteboard: [mentor=margaret][lang=css][lang=js])

Attachments

(1 file)

Since we're switching over to Clear Sans, we need to update our text style menu. 

It should read "Clear Sans" and show the right preview for it as well.
There are two parts to this bug. First, let's make sure we replace all uses of "Open Sans" with "Clear Sans" in aboutReader.css:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css

Then we need to update the string here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/chrome/aboutReader.properties#16

We should change the property name when we do that, and that will involve also updating where it's used here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutReader.js#84
Depends on: 877203
OS: Mac OS X → Android
Hardware: x86 → ARM
Whiteboard: [mentor=margaret][lang=css][lang=js]
If the above three files were the only ones that needed to be changed, I'm done with it and can submit a patch if you want.
(In reply to Nicolas Carlo from comment #2)
> If the above three files were the only ones that needed to be changed, I'm
> done with it and can submit a patch if you want.

Yeah, that sounds great! Do you have the bugzilla powers to assign yourself to a bug? If not, I'll get someone to give those to you :)

We'll have to wait for bug 877203 to land before we land this, but it's nice to have a patch waiting in the wings.
Cool. I'll submit the patch by tonight or tomorrow morning.

I can't assign bugs to myself but if I could somehow, that'd be awesome. Thanks
Assignee: nobody → nickecarlo
(In reply to Nicolas Carlo from comment #4)

> I can't assign bugs to myself but if I could somehow, that'd be awesome.

You should have editbugs privileges now. Congrats! :)
(In reply to :Margaret Leibovic from comment #5)
> (In reply to Nicolas Carlo from comment #4)
> 
> > I can't assign bugs to myself but if I could somehow, that'd be awesome.
> 
> You should have editbugs privileges now. Congrats! :)

Thanks a lot for giving me editbugs privileges. :D It feels awesome.
Comment on attachment 756329 [details] [diff] [review]
Update our text style menu, replace references to Open Sans with Clear Sans

This looks great. We'll just wait for bug 877203 to land, and then we can land this.
Attachment #756329 - Flags: review?(margaret.leibovic) → review+
This does not seem to have landed back then, but the style menu says "Clear Sans" by now anyway. Is there anything else left to do in this bug now or can it be closed?
Flags: needinfo?(margaret.leibovic)
Ah looks like this got fixed as part of bug 877203. We can close it out.

Nicolas, I'm sorry that I failed to follow up on this once bug 877203 landed! Let me know if you want help finding other bugs to work on :)
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(margaret.leibovic)
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
(In reply to :Margaret Leibovic from comment #10)
> Ah looks like this got fixed as part of bug 877203. We can close it out.
> 
> Nicolas, I'm sorry that I failed to follow up on this once bug 877203
> landed! Let me know if you want help finding other bugs to work on :)

Hey Margaret:

Heh. Its alright. I'd completely forgotten about this myself.

Sorry I fell off the face of the earth. I was studying for my final year of college and doing a project that made it impossible for me to do any development work.

I am going to set up my system once again for Fennec development and hopefully start working on bugs soon. Thanks for the offer to help, I'll definitely let you know if I can't find my way around here :)
You need to log in before you can comment on or make changes to this bug.