877791 - Follow-up: Finalize strings for first phase of settings rework

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Chenxia Liu [:liuche]]

Bug 872329 applies a new settings organization to Fennec preferences.

This bug is to make sure to remove old strings once we know we won't use them, and to tweak any strings necessary before uplift to Aurora.

Comment 1

[Chenxia Liu [:liuche]]

These have been in Nightly for a while. How do the strings look? If we're not thinking about changing any strings, I can make a patch to remove all the old (unused) settings strings.

Comment 2

[Ian Barlow (:ibarlow)]

Chenxia, generally things are looking good to me. 

I don't really like "Double tap to reflow text", and I want to rethink the way we explain "Always restore tabs", but I can file follow-ups for that if you want to uplift the work to date.

Comment 3

[Chenxia Liu [:liuche]]

No problem. I actually mistyped earlier, I meant merge not uplift. If the current strings that were changed all look good, and the only ones you want to rethink are "Double tap to reflow text" and "Always restore tabs", I'll make a patch to remove the old strings I've left hanging around.

As long as we get these in before the merge of 25 to aurora, I'm happy to add new strings whenever you like.

Comment 4

[Chenxia Liu [:liuche]]

Hi Ian, just a little poke to get some finalized strings to me because merge is in a week (and a reminder to myself so I don't forget!).

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Merge day is Monday August 5th - so yes, let's get this in asap.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

"Always restore tabs" is being handled in bug 896515

Comment 7

[Ian Barlow (:ibarlow)]

(In reply to Chenxia Liu [:liuche] from comment #4)
> Hi Ian, just a little poke to get some finalized strings to me because merge
> is in a week (and a reminder to myself so I don't forget!).

As we discussed in IRC yesterday, I think we're still figuring out to do with the 'Double tap to reflow text' feature in general, but for now we can make a few changes to before string freeze. 

* change its name to "Reflow text"
* add an "advanced" divider

So the new list would look like https://etherpad.mozilla.org/settings-display

Between this and the work happening in bug 896515 we should be good to finish up here.

Comment 8

[Ian Barlow (:ibarlow)]

Sorry Chenxia, there was actually one more thing I'd like us to look at. 

I'm concerned about the title "Search" under Customize. For someone who might not be aware that you can adjust settings in there, it could be misunderstood as a place wherein you actually *search your settings*... 

Perhaps we could try renaming the row to read "Edit search settings". Wordy I know, but less prone to misinterpretation.

Comment 9

[Chenxia Liu [:liuche]]

Sure, I can do that as well.

And just to double check, did you want the text to be "Reflow text" or "Text reflow"? It's one in the bug, and a different one in the etherpad.

Comment 10

[Ian Barlow (:ibarlow)]

Sorry, "Text reflow" :P

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Ian Barlow (:ibarlow) from comment #8)

> Perhaps we could try renaming the row to read "Edit search settings". Wordy
> I know, but less prone to misinterpretation.

Jumping in late, but what about "Search settings"? I think the "Edit" could be a bit redundant. Yes, "settings" is redundant too, but better to have one less redundant word in the text.

Comment 12

[Ian Barlow (:ibarlow)]

> > Perhaps we could try renaming the row to read "Edit search settings". Wordy
> > I know, but less prone to misinterpretation.
> 
> Jumping in late, but what about "Search settings"? I think the "Edit" could
> be a bit redundant. Yes, "settings" is redundant too, but better to have one
> less redundant word in the text.

Sure, let's try it and see.

Comment 13

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Search settings as menu item

Comment 14

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Search settings screen

Comment 15

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Display screen

Comment 16

[Chenxia Liu [:liuche]]

Attachment: Patch: String changes and add advanced category to display v1

Comment 17

[Ian Barlow (:ibarlow)]

Love it all, let's ship it :)

Comment 18

[Chenxia Liu [:liuche]]

Attachment: Patch: String changes and add advanced category to display v2

Updated settings tests.

Comment 19

[Chenxia Liu [:liuche]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=1003a2956fa7

Comment 20

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9f93aa72c9

Comment 21

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a9f93aa72c9

Comment 22

[Ed Morley [:emorley]]

Please can bugs changing these parts of the tree land on fx-team in the future to help balance load & avoid conflicts (for more info see Gavin's newsgroup post: https://mail.mozilla.org/pipermail/firefox-dev/2013-July/000618.html). Thank you :-)

Comment 23

[Thomas Stache]

(In reply to Ian Barlow (:ibarlow) from comment #8)
> Sorry Chenxia, there was actually one more thing I'd like us to look at. 
> 
> I'm concerned about the title "Search" under Customize. For someone who
> might not be aware that you can adjust settings in there, it could be
> misunderstood as a place wherein you actually *search your settings*... 
> 
> Perhaps we could try renaming the row to read "Edit search settings". Wordy
> I know, but less prone to misinterpretation.

Excuse me, but for me (as a German) the new string "Search settings" doesn't sound any different - but like searching through the settings!?

Comment 24

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Thomas Stache from comment #23)
> (In reply to Ian Barlow (:ibarlow) from comment #8)
> > Sorry Chenxia, there was actually one more thing I'd like us to look at. 
> > 
> > I'm concerned about the title "Search" under Customize. For someone who
> > might not be aware that you can adjust settings in there, it could be
> > misunderstood as a place wherein you actually *search your settings*... 
> > 
> > Perhaps we could try renaming the row to read "Edit search settings". Wordy
> > I know, but less prone to misinterpretation.
> 
> Excuse me, but for me (as a German) the new string "Search settings" doesn't
> sound any different - but like searching through the settings!?

Yes, it's imperfect, but thankfully you can tap on the field and figure it out. I still feel using a more simple string is better than an overly explicit string. Our setting captions would look ridiculous if they were all overly explicit.