Closed Bug 877791 Opened 6 years ago Closed 6 years ago

Follow-up: Finalize strings for first phase of settings rework

Categories

(Firefox for Android :: Theme and Visual Design, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25
Tracking Status
firefox25 + fixed

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(4 files, 1 obsolete file)

Bug 872329 applies a new settings organization to Fennec preferences.

This bug is to make sure to remove old strings once we know we won't use them, and to tweak any strings necessary before uplift to Aurora.
These have been in Nightly for a while. How do the strings look? If we're not thinking about changing any strings, I can make a patch to remove all the old (unused) settings strings.
Flags: needinfo?(ibarlow)
Chenxia, generally things are looking good to me. 

I don't really like "Double tap to reflow text", and I want to rethink the way we explain "Always restore tabs", but I can file follow-ups for that if you want to uplift the work to date.
Flags: needinfo?(ibarlow)
No problem. I actually mistyped earlier, I meant merge not uplift. If the current strings that were changed all look good, and the only ones you want to rethink are "Double tap to reflow text" and "Always restore tabs", I'll make a patch to remove the old strings I've left hanging around.

As long as we get these in before the merge of 25 to aurora, I'm happy to add new strings whenever you like.
Hi Ian, just a little poke to get some finalized strings to me because merge is in a week (and a reminder to myself so I don't forget!).
Flags: needinfo?(ibarlow)
Merge day is Monday August 5th - so yes, let's get this in asap.
"Always restore tabs" is being handled in bug 896515
Assignee: nobody → liuche
(In reply to Chenxia Liu [:liuche] from comment #4)
> Hi Ian, just a little poke to get some finalized strings to me because merge
> is in a week (and a reminder to myself so I don't forget!).

As we discussed in IRC yesterday, I think we're still figuring out to do with the 'Double tap to reflow text' feature in general, but for now we can make a few changes to before string freeze. 

* change its name to "Reflow text"
* add an "advanced" divider

So the new list would look like https://etherpad.mozilla.org/settings-display

Between this and the work happening in bug 896515 we should be good to finish up here.
Flags: needinfo?(ibarlow)
Sorry Chenxia, there was actually one more thing I'd like us to look at. 

I'm concerned about the title "Search" under Customize. For someone who might not be aware that you can adjust settings in there, it could be misunderstood as a place wherein you actually *search your settings*... 

Perhaps we could try renaming the row to read "Edit search settings". Wordy I know, but less prone to misinterpretation.
Sure, I can do that as well.

And just to double check, did you want the text to be "Reflow text" or "Text reflow"? It's one in the bug, and a different one in the etherpad.
Flags: needinfo?(ibarlow)
Sorry, "Text reflow" :P
Flags: needinfo?(ibarlow)
(In reply to Ian Barlow (:ibarlow) from comment #8)

> Perhaps we could try renaming the row to read "Edit search settings". Wordy
> I know, but less prone to misinterpretation.

Jumping in late, but what about "Search settings"? I think the "Edit" could be a bit redundant. Yes, "settings" is redundant too, but better to have one less redundant word in the text.
> > Perhaps we could try renaming the row to read "Edit search settings". Wordy
> > I know, but less prone to misinterpretation.
> 
> Jumping in late, but what about "Search settings"? I think the "Edit" could
> be a bit redundant. Yes, "settings" is redundant too, but better to have one
> less redundant word in the text.

Sure, let's try it and see.
Attachment #784565 - Flags: review?(ibarlow)
Attachment #784566 - Flags: review?(ibarlow)
Attachment #784568 - Flags: review?(ibarlow)
Love it all, let's ship it :)
Updated settings tests.
Attachment #784569 - Attachment is obsolete: true
Attachment #784575 - Flags: review?(bnicholson)
Status: NEW → ASSIGNED
Attachment #784575 - Flags: review?(bnicholson) → review+
Attachment #784565 - Flags: review?(ibarlow)
Attachment #784566 - Flags: review?(ibarlow)
Attachment #784568 - Flags: review?(ibarlow)
https://hg.mozilla.org/mozilla-central/rev/3a9f93aa72c9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Please can bugs changing these parts of the tree land on fx-team in the future to help balance load & avoid conflicts (for more info see Gavin's newsgroup post: https://mail.mozilla.org/pipermail/firefox-dev/2013-July/000618.html). Thank you :-)
(In reply to Ian Barlow (:ibarlow) from comment #8)
> Sorry Chenxia, there was actually one more thing I'd like us to look at. 
> 
> I'm concerned about the title "Search" under Customize. For someone who
> might not be aware that you can adjust settings in there, it could be
> misunderstood as a place wherein you actually *search your settings*... 
> 
> Perhaps we could try renaming the row to read "Edit search settings". Wordy
> I know, but less prone to misinterpretation.

Excuse me, but for me (as a German) the new string "Search settings" doesn't sound any different - but like searching through the settings!?
(In reply to Thomas Stache from comment #23)
> (In reply to Ian Barlow (:ibarlow) from comment #8)
> > Sorry Chenxia, there was actually one more thing I'd like us to look at. 
> > 
> > I'm concerned about the title "Search" under Customize. For someone who
> > might not be aware that you can adjust settings in there, it could be
> > misunderstood as a place wherein you actually *search your settings*... 
> > 
> > Perhaps we could try renaming the row to read "Edit search settings". Wordy
> > I know, but less prone to misinterpretation.
> 
> Excuse me, but for me (as a German) the new string "Search settings" doesn't
> sound any different - but like searching through the settings!?

Yes, it's imperfect, but thankfully you can tap on the field and figure it out. I still feel using a more simple string is better than an overly explicit string. Our setting captions would look ridiculous if they were all overly explicit.
You need to log in before you can comment on or make changes to this bug.