Last Comment Bug 877798 - Fix ssltap to print the correct label certificate_status (not request)
: Fix ssltap to print the correct label certificate_status (not request)
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.15
: All All
: P2 normal (vote)
: 3.15.1
Assigned To: Kai Engert (:kaie)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-30 12:13 PDT by Kai Engert (:kaie)
Modified: 2013-06-26 06:36 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (1.70 KB, patch)
2013-05-30 12:15 PDT, Kai Engert (:kaie)
wtc: review+
Details | Diff | Splinter Review

Description Kai Engert (:kaie) 2013-05-30 12:13:21 PDT
ssltap labels the server's certificate status response as certificate_status_request, but it should say certificate_status.
Comment 1 Kai Engert (:kaie) 2013-05-30 12:15:28 PDT
Created attachment 756124 [details] [diff] [review]
Patch v1
Comment 2 Wan-Teh Chang 2013-05-30 17:20:13 PDT
Comment on attachment 756124 [details] [diff] [review]
Patch v1

Review of attachment 756124 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

::: cmd/ssltap/ssltap.c
@@ +1317,5 @@
>  	  sslh.length += s->hMACsize;  /* skip over the MAC data */
>        }
>        break;
>  
> +    case 22: /*certificate_status*/

Please add a space before and after certificate_status in the comment, like this:

    case 22: /* certificate_status */
Comment 4 Wan-Teh Chang 2013-06-25 18:14:38 PDT
Kai: your checkin https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6
included a change to secoid.c by mistake. Please revert that change.
Comment 5 Kai Engert (:kaie) 2013-06-26 06:36:26 PDT
(In reply to Wan-Teh Chang from comment #4)
> Kai: your checkin https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6
> included a change to secoid.c by mistake. Please revert that change.

Sorry about that! It sneaked when I tried to reproduce an reported issue...

Thanks for noticing the mistake.
Reverted:
https://hg.mozilla.org/projects/nss/rev/b1275e1acf8a

Note You need to log in before you can comment on or make changes to this bug.