877798 - Fix ssltap to print the correct label certificate_status (not request)

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Kai Engert [:KaiE:]]

ssltap labels the server's certificate status response as certificate_status_request, but it should say certificate_status.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch v1

Comment 2

[Wan-Teh Chang]

Comment on attachment 756124 [details] [diff] [review]
Patch v1

Review of attachment 756124 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

::: cmd/ssltap/ssltap.c
@@ +1317,5 @@
>  	  sslh.length += s->hMACsize;  /* skip over the MAC data */
>        }
>        break;
>  
> +    case 22: /*certificate_status*/

Please add a space before and after certificate_status in the comment, like this:

    case 22: /* certificate_status */

Comment 3

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6
https://hg.mozilla.org/projects/nss/rev/23e6ea72c93f

Comment 4

[Wan-Teh Chang]

Kai: your checkin https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6
included a change to secoid.c by mistake. Please revert that change.

Comment 5

[Kai Engert [:KaiE:]]

(In reply to Wan-Teh Chang from comment #4)
> Kai: your checkin https://hg.mozilla.org/projects/nss/rev/84dbcfce41d6
> included a change to secoid.c by mistake. Please revert that change.

Sorry about that! It sneaked when I tried to reproduce an reported issue...

Thanks for noticing the mistake.
Reverted:
https://hg.mozilla.org/projects/nss/rev/b1275e1acf8a