877809 - Disable RTTI for every platform, not only tier1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Landry Breuil (:gaston)]

After bug 844288, gtest is now enabled by default on all platforms (like, even the BSDs) but it wasnt the case before. Thing is, GTEST_HAVE_RTTI isnt set to 0 like on tier1 platforms, and thus the build fails :

In file included from ../../dist/system_wrappers/tr1/functional:2:
/usr/include/g++/tr1/functional:906:51: error: cannot use typeid with -fno-rtti
          __dest._M_access<const type_info*>() = &typeid(_Functor);

(see bug 844288 comment 60)

I dont mind having gtest enabled on OpenBSD (and it seems that it's enabled there even if it's not listed in configure.in line ~6391, where only tier1 plats are listed), but RTTI should be disabled for everyone.

Comment 1

[Benoit Girard (:BenWa)]

Note that GTest relinks libxul on-demand (when running make check) with additional library. If you're hitting linker memory limits then it will fail before the default libxul linking step does.

Comment 2

[Landry Breuil (:gaston)]

Attachment: Set GTEST_HAS_RTTI=0 on all platforms, not only tier1

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 756559 [details] [diff] [review]
Set GTEST_HAS_RTTI=0 on all platforms, not only tier1

Review of attachment 756559 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +6394,1 @@
>      if test "${OS_TARGET}" = "WINNT" -o "${OS_TARGET}" = "Darwin" -o "${OS_TARGET}" = "Linux" -o "${OS_TARGET}" = "Android"; then

I think we should just remove the 'if test ...' line entirely and use GTest everywhere.

Comment 4

[Benoit Girard (:BenWa)]

I've rolled this patch into my patch. This will be fixed once bug 844288 lands.

Comment 5

[Benoit Girard (:BenWa)]

Rode along with https://hg.mozilla.org/mozilla-central/rev/1c257409f5a6