mozprocess tests do not seem to clean up proclaunch (and other?)

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jeff Hammel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
From https://bugzilla.mozilla.org/show_bug.cgi?id=844288#c55 onward
vis a viz https://bugzilla.mozilla.org/show_bug.cgi?id=790765#c74 :


The mozprocess test does not appear to remove the proclaunch binary
following the run. It should and it should be ensured that other
ephemeral artefacts are also removed (save when running with
DEBUG=1). In addition if this is falliable the tests package should be
generated in such a way that any "droppings" are excluded.  However,
it is IMHO probably easier to just make this (practically) infalliable.
(Reporter)

Updated

5 years ago
Blocks: 790765
(Reporter)

Updated

5 years ago
Blocks: 778267
(Reporter)

Updated

5 years ago
No longer blocks: 790765
(In reply to Jeff Hammel [:jhammel] from comment #0)
> From https://bugzilla.mozilla.org/show_bug.cgi?id=844288#c55 onward
> vis a viz https://bugzilla.mozilla.org/show_bug.cgi?id=790765#c74 :
> 
> 
> The mozprocess test does not appear to remove the proclaunch binary
> following the run. It should and it should be ensured that other
> ephemeral artefacts are also removed (save when running with
> DEBUG=1).

I think Mozprocess now does cleanup, I'm not sure about the DEBUG variable, but it uses a CLEANUP env-variable to decide if cleanup is required.

https://github.com/mozilla/mozbase/blob/master/mozprocess/tests/test_mozprocess.py#L102-L121


> In addition if this is falliable the tests package should be
> generated in such a way that any "droppings" are excluded.  However,
> it is IMHO probably easier to just make this (practically) infalliable.

I didn't quite understand what you meant by this bit Jeff, can you please elaborate?
Flags: needinfo?(jhammel)
(Reporter)

Comment 2

5 years ago
(In reply to Anhad Jai Singh (:ffledgling) from comment #1)
> (In reply to Jeff Hammel [:jhammel] from comment #0)
> > From https://bugzilla.mozilla.org/show_bug.cgi?id=844288#c55 onward
> > vis a viz https://bugzilla.mozilla.org/show_bug.cgi?id=790765#c74 :
> > 
> > 
> > The mozprocess test does not appear to remove the proclaunch binary
> > following the run. It should and it should be ensured that other
> > ephemeral artefacts are also removed (save when running with
> > DEBUG=1).
> 
> I think Mozprocess now does cleanup, I'm not sure about the DEBUG variable,
> but it uses a CLEANUP env-variable to decide if cleanup is required.
> 
> https://github.com/mozilla/mozbase/blob/master/mozprocess/tests/
> test_mozprocess.py#L102-L121

Yeah, this is fixed enough.  Will close.

> > In addition if this is falliable the tests package should be
> > generated in such a way that any "droppings" are excluded.  However,
> > it is IMHO probably easier to just make this (practically) infalliable.
> 
> I didn't quite understand what you meant by this bit Jeff, can you please
> elaborate?

I mostly meant that since this involves a list of files, changing e.g. how proclaunch is built, will not update tearDownClass.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(jhammel)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.