877837 - Add hu and tr to multi-locale APK for Fx23

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jeff Beatty [:gueroJeff]]

Add hu and tr to mobile/android/locales/maemo-locales, then upstream to Aurora and Central.

Comment 1

[Jeff Beatty [:gueroJeff]]

Attachment: Adds hu & tr to mozilla-beta/mobile/android/locales/maemo-locales

Comment 2

[Aaron Train [:aaronmt]]

Beta 3 was just shipped. Can we have some context on these additions?

Comment 3

[Tony Chung [:tchung]]

This was on the roadmap for Fx23 and at risk.  why is this coming in so late?

https://wiki.mozilla.org/Mobile/Roadmap12-13#Firefox_23:_Real_Media_.28Aurora.29

Comment 4

[Jeff Beatty [:gueroJeff]]

(In reply to Tony Chung [:tchung] from comment #3)
> This was on the roadmap for Fx23 and at risk.  why is this coming in so late?
> 
> https://wiki.mozilla.org/Mobile/Roadmap12-13#Firefox_23:_Real_Media_.
> 28Aurora.29

My apologies, this was a misunderstanding on my part. This is meant for Firefox 23, not Beta. I'll rename the bug.

Comment 5

[Jeff Beatty [:gueroJeff]]

(In reply to jbeatty from comment #4)
> (In reply to Tony Chung [:tchung] from comment #3)
> > This was on the roadmap for Fx23 and at risk.  why is this coming in so late?
> > 
> > https://wiki.mozilla.org/Mobile/Roadmap12-13#Firefox_23:_Real_Media_.
> > 28Aurora.29
> 
> My apologies, this was a misunderstanding on my part. This is meant for
> Firefox 23, not Beta. I'll rename the bug.

It also doesn't need to be added to Central. Only Aurora.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 756189 [details] [diff] [review]
Adds hu & tr to mozilla-beta/mobile/android/locales/maemo-locales

Review of attachment 756189 [details] [diff] [review]:
-----------------------------------------------------------------

So, this should be against aurora, not beta. r=me for that.

Comment 7

[Jeff Beatty [:gueroJeff]]

Comment on attachment 756189 [details] [diff] [review]
Adds hu & tr to mozilla-beta/mobile/android/locales/maemo-locales

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Is there anything that can be done to track that this change is uplifted to Beta at the next migration?

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

I put a note in our merge documentation not to revert to beta 22 multilocales (https://wiki.mozilla.org/Release_Management/Merge_Documentation#L10n_data_changes)

Comment 9

[Jeff Beatty [:gueroJeff]]

(In reply to [e-mail] [:lsblakk] from comment #8)
> I put a note in our merge documentation not to revert to beta 22
> multilocales
> (https://wiki.mozilla.org/Release_Management/
> Merge_Documentation#L10n_data_changes)

Great! Thank you.

I currently don't have commit access, can I ask someone to push this for me please?

Comment 10

[Axel Hecht [:Pike]]

Landed as https://hg.mozilla.org/releases/mozilla-aurora/rev/0b4c636386c1.

Marking FIXED, and fixed23, but not fixed24, because that'll only happen once we have done the next migration, and not overwritten the state of aurora with central, but overwritten beta with aurora. I hope that makes sense, aurora stays as it is, plus migrates to beta, central looses and stays on central only.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Test Cases added in moztrap:
Hungarian: https://moztrap.mozilla.org/manage/case/8443/
Turkish: https://moztrap.mozilla.org/manage/case/8444