877995 - IndexedDB should set a stack quotum when creating a JS runtime

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Eddy Bruel [:ejpbruel]]

IDBObjectStore creates a new JS runtime. Whenever we do this, we also need to set a stack quotum. Not doing this could cause JS_CHECK_RECURSION to report false positives.

This is blocking us from landing bug 637572.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Single line fix

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 756440 [details] [diff] [review]
Single line fix

Review of attachment 756440 [details] [diff] [review]:
-----------------------------------------------------------------

IDB shouldn't need much stack space here.  I'm not sure what the minimum is but I think we could get by with even less if possible.

Anyways r=me.

::: dom/indexedDB/IDBObjectStore.cpp
@@ +525,5 @@
> +    /*
> +     * Not setting this will cause JS_CHECK_RECURSION to report false
> +     * positives
> +     */
> +    JS_SetNativeStackQuota(mRuntime, 128 * sizeof(size_t) * 1024); 

Extra whitespace at EOL.

Comment 3

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/466760822586

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/466760822586