878029 - Update GetDefaultScaleInternal() for FxOS to match AOSP spec

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for review

+++ This bug was initially created as a clone of Bug #845182 +++

See dev-b2g: "Proposal: Amend the device-pixel-ratio calculation in Gonk (FxOS) to match AOSP spec", I would like to amend how we the device-pixel-ratio calculation in Gonk.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 756510 [details] [diff] [review]
Patch for review

You managed to submit a patch with zero context lines. This function is pretty simple so I guess it doesn't matter much, but something sounds misconfigured on your side. :)

No context appears to break the splinter review tool..

Anyway, I only have one nit: put the "// * devices." comments on the same line as the return.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 756510 [details] [diff] [review]
Patch for review

Yeah it was Friday night here and I want to have the patch on Bugzilla for review first :)

I am going to make sure the change compiles locally before sending out a patch for commit.

Thank you :)

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for commit

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/8b1bfcf0ce6e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b1bfcf0ce6e

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/e6683cf3055b