Closed Bug 878029 Opened 8 years ago Closed 8 years ago

Update GetDefaultScaleInternal() for FxOS to match AOSP spec

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:hd+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 wontfix, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

VERIFIED FIXED
blocking-b2g hd+
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- wontfix
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch for review (obsolete) — Splinter Review
+++ This bug was initially created as a clone of Bug #845182 +++

See dev-b2g: "Proposal: Amend the device-pixel-ratio calculation in Gonk (FxOS) to match AOSP spec", I would like to amend how we the device-pixel-ratio calculation in Gonk.
Attachment #756510 - Flags: review?(mwu)
Comment on attachment 756510 [details] [diff] [review]
Patch for review

You managed to submit a patch with zero context lines. This function is pretty simple so I guess it doesn't matter much, but something sounds misconfigured on your side. :)

No context appears to break the splinter review tool..

Anyway, I only have one nit: put the "// * devices." comments on the same line as the return.
Attachment #756510 - Flags: review?(mwu) → review+
Comment on attachment 756510 [details] [diff] [review]
Patch for review

Yeah it was Friday night here and I want to have the patch on Bugzilla for review first :)

I am going to make sure the change compiles locally before sending out a patch for commit.

Thank you :)
blocking-b2g: --- → hd+
Attachment #756510 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/8b1bfcf0ce6e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.1 QE3 (24jun)
Target Milestone: 1.1 QE3 (24jun) → ---
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.