878106 - Cut/Copy/Paste edit controls don't copy and paste non-form content text properly

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Select some non-form text on a page
2) Open the menu panel and click "copy" to copy it to the clipboard
3) Choose the search input in the nav-bar
4) Open the menu panel

What happens?

Paste is disabled.

What's expected?

Paste should be enabled, and clicking on it should paste the clipboard contents into the search input.

Comment 1

[Mike de Boer [:mikedeboer]]

I think it's worth to mention that this works as expected (for me) on Mac OSX and Linux (Ubuntu). Should we change the platform flags?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Removing the items from M7 that do not block landing on m-c.

Comment 3

[:Gijs (he/him)]

This WFM on Windows and OS X. Mike (C), can you still reproduce this? :-)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Yep.

http://screencast.com/t/36Fo0hoUbt

What's worse, is that when I click on the button, the panel closes now (it didn't do this before), which gives me the impression that something happened...but the paste didn't happen. I guess that's a separate bug though.

Comment 5

[:Gijs (he/him)]

Attachment: should call updateEditUIVisibility when opening panel,

Realized this was just a question of calling updateEditUIVisibility in the ri ght places, like we do for menus. Whoops!

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 777738 [details] [diff] [review]
should call updateEditUIVisibility when opening panel,

Review of attachment 777738 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/content/panelUI.js
@@ +78,5 @@
>        this.hide();
>      } else if (this.panel.state == "closed") {
>        this.ensureRegistered();
>        this.panel.hidden = false;
> +      let editControlPlacement = CustomizableUI.getPlacementOfWidget('edit-controls');

Nit: Convention is double quotes.

Comment 7

[:Gijs (he/him)]

Pushed with nits fixed, https://hg.mozilla.org/projects/ux/rev/4a71a1c953d6

Comment 8

[:Gijs (he/him)]

Egh, I meant 

> Pushed with nits fixed, https://hg.mozilla.org/projects/ux/rev/c14e95e3b87f

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/c14e95e3b87f

Comment 10

[ganesh_sahai1]

Tested on :---
User Agent : Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0
Version : Firefox  28.0a1
Platform Tested : x86_64, Win 8

Status : Found Fixed.

Comment 11

[u279076]

Marking this verified based on comment 10. Thanks for your help Ganesh.