Closed
Bug 878126
Opened 11 years ago
Closed 11 years ago
Subscribe button has no icon in the customization palette for Retina displays
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mikedeboer)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [Australis:M7])
Attachments
(1 file, 1 obsolete file)
|
1.33 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
STR:
1) In OSX with a Retina display, enter customization mode
2) Look at the subscribe icon
It has no icon. :/
See http://cl.ly/image/3R3S3h0v0N16
|
||
Updated•11 years ago
|
Whiteboard: [Australis:M?] → [Australis:M7]
|
|
||
Comment 1•11 years ago
|
||
Stephen, I think we'll need an upscaled icon for this.
Assignee: nobody → shorlander
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
There is an @2x icon in the menuPanel-icons@2x.png sprite
|
|
||
Updated•11 years ago
|
Assignee: shorlander → mdeboer
|
Assignee | |
Comment 3•11 years ago
|
||
Mike, this is a patch that fixes it, but in a dirty way... (old) XUL button selectors, `#feed-button` in this case, take precedence over the descendant selector inside the hidpi media query block.
I can take this route, but I could also add more selectors to define the list-image that are more specific and include the XUL button ids (using `@primaryToolbarButtons@`?).
Attachment #761998 -
Flags: feedback?(mconley)
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 761998 [details] [diff] [review]
Fix HiDPI icons for XUL buttons inside the customization palette
Review of attachment 761998 [details] [diff] [review]:
-----------------------------------------------------------------
Hm, yeah, I don't prefer this solution.
Using @primaryToolbarButtons@ in a :-moz-any sounds like a better solution. Perhaps these rules can go directly in browser.css after the .toolbarbutton-1 rules.
Attachment #761998 -
Flags: feedback?(mconley)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #761998 -
Attachment is obsolete: true
Attachment #762024 -
Flags: review?(mconley)
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 762024 [details] [diff] [review]
Fix HiDPI icons for XUL buttons inside the customization palette
Review of attachment 762024 [details] [diff] [review]:
-----------------------------------------------------------------
This looks right to me. Thanks Mike!
Attachment #762024 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
|
|
Reporter | |
Comment 7•11 years ago
|
||
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•