878196 - Some dates in reader mode show up as ?

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P4)

Description

[Nicolas Carlo [:nickecarlo]]

While testing Reader Mode on the following page: http://mattgemmell.com/2008/12/08/what-have-you-tried/ I noticed that the date (Dec 8th, 2008) shows up as a ? when I switch to Reader Mode.

Comment 1

[Aaron Train [:aaronmt]]

That is weird.

That date has the markup of the date:

<time datetime="2008-12-08T17:00:46+00:00" pubdate="" data-updated="true">Dec 8<span>th</span>, 2008</time>

Comment 2

[:Margaret Leibovic]

This sounds like an issue with Readability.js. Brian, what do you think? Also, what's the process for dealing with bugs in that script?

Comment 3

[Brian Nicholson (:bnicholson)]

My initial thought was that the date element was just ignored as part of the reader algorithm, but it's strange that that a "?" would appear in its place. To start with, I'd look at the HTML of the reader-parsed page using the remote debugger to see what's being generated. There's no special process for committing changes to that file that I know of.

Lucas ported this over and has touched it a lot, so CC'ing him in case he has any thoughts.

Comment 4

[:Margaret Leibovic]

Since this bug was filed, we have changed the byline parsing logic, so this issue doesn't appear anymore.

I tried moving this troublesome date markup into the main content of the page to make sure there isn't anything else bad going on there, and we appear to parse this correctly as part of the article content:
http://people.mozilla.org/~mleibovic/test/date.html

So I'm closing this out.