878204 - Add moznetwork to test package

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

I forgot to make sure that moznetwork gets added to the test package in bug 876761

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Add moznetwork to test package

Comment 2

[Jeff Hammel]

Comment on attachment 756791 [details] [diff] [review]
Patch 1.0 - Add moznetwork to test package

r+

Could you file a follow up (especially if you know the answer to any of these questions) regarding making this more betterer?

- did you use generate_diff.py to mirror?  IIRC (which I very well may not), it *should* update packages.txt; in any case, if it doesn't...it should

- cutoff in the patch, but from http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/Makefile.in#15:

  """
  # python packages to be installed IN INSTALLATION ORDER.
  # Packages later in the list can depend only on packages earlier in the list.
  """

  IIRC (which again...) this is no longer true; or more correctly, we do not install them in the `python setup.py {develop|install}` sense anywhere.  Do you know if this is true?  If not...it should be corrected.

- similarly for this list....it'd be nice to have this autogenerated. This could mean taking this out of the makefile or, if someone knows make magic, reading them from a file generated concurrently to packages.txt

If you don't want to file the follow up, :ahal, I'm fine doing so.  I just figured that since you've touched this area recently, you'd have some idea/insight as to how this all works.

Comment 3

[Andrew Halberstadt [:ahal]]

> - did you use generate_diff.py to mirror?  IIRC (which I very well may not),
> it *should* update packages.txt; in any case, if it doesn't...it should

It probably does, I didn't use it.

> - cutoff in the patch, but from
> http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/Makefile.in#15:
> 
>   """
>   # python packages to be installed IN INSTALLATION ORDER.
>   # Packages later in the list can depend only on packages earlier in the
> list.
>   """
> 
>   IIRC (which again...) this is no longer true; or more correctly, we do not
> install them in the `python setup.py {develop|install}` sense anywhere.  Do
> you know if this is true?  If not...it should be corrected.

I have no idea if this is still true or not. If all this is for is making sure the packages get copied to the tests.zip, then I would guess no. I'll poke around and remove the comment if I don't see anything.

> - similarly for this list....it'd be nice to have this autogenerated. This
> could mean taking this out of the makefile or, if someone knows make magic,
> reading them from a file generated concurrently to packages.txt
> 
> If you don't want to file the follow up, :ahal, I'm fine doing so.  I just
> figured that since you've touched this area recently, you'd have some
> idea/insight as to how this all works.

I don't have any insight on how this works. In fact for my purposes I don't think I even need moznetwork listed here (as long as it gets copied to the test package), but I assume that this will be needed for other reasons eventually anyway. I think autogeneration, while nice, probably isn't worth our time as we don't really add new packages all too often.

Comment 4

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f65c0c7ee67d

Pretty sure you are right and the list of packages in the makefile is only used to copy mozbase to the test package. I also noticed that mozcrash was listed twice.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f65c0c7ee67d

Comment 6

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a40cd59ba7f7
https://hg.mozilla.org/releases/mozilla-beta/rev/a6fae2c0dcf4
https://hg.mozilla.org/releases/mozilla-release/rev/3b087c81c1f7