options("werror") shouldn't affect asm.js diagnostics

NEW
Unassigned

Status

()

Core
JavaScript Engine
5 years ago
3 years ago

People

(Reporter: Jesse Ruderman, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
ams.js always "warns" so it doesn't make sense for werror to stop it from working.

js> (function() { "use asm"; function g(){ return 3; } return g; })()()
warning: successfully compiled asm.js code
3

js> options("werror")

js> (function() { "use asm"; function g(){ return 3; } return g; })()()
successfully compiled asm.js code
We discovered this while fuzzing using jsfunfuzz, but have worked around it so while the fix isn't pressing, it will be nice if this could be resolved.
(Reporter)

Comment 2

5 years ago
I discovered this manually.  jsfunfuzz doesn't use options("werror").
(In reply to Jesse Ruderman from comment #2)
> I discovered this manually.  jsfunfuzz doesn't use options("werror").

Oh, seems like I confused this with another bug then. :-/
For a long time we've thought warnings should be a first-class API feature, not something vaguely overloaded via the error reporting syntax.  This might be sufficient motivation to implement that, seems to me.
(Assignee)

Updated

3 years ago
Assignee: general → nobody
You need to log in before you can comment on or make changes to this bug.