878379 - Change the walker's querySelector requests to provide any nodes needed to connect to the root node

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

There are two requests on the inspector, querySelector() and querySelectorAll(), that let the client find nodes without having previously seen all of its parents.  This patch changes those request to also return all nodes that the client hasn't seen that are needed to connect to the root node.

This will be used in a later patch to let the client have a real ownership tree of nodes it has seen.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1.1

Comment 2

[Dave Camp (:dcamp)]

Attachment: v1.2

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 756983 [details] [diff] [review]
v1.2

Review of attachment 756983 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +341,5 @@
>     * Get a single node from the node list.
>     */
>    item: method(function(index) {
> +    let node = this.walker._ref(this.nodeList[index]);
> +    let newNodes = [node for (node of this.walker.ensurePathToRoot(node))];

Could we make the remote protocol cognisant of Sets?

Comment 4

[Dave Camp (:dcamp)]

(In reply to Joe Walker [:jwalker] from comment #3)
> Comment on attachment 756983 [details] [diff] [review]
> v1.2
> 
> Review of attachment 756983 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/devtools/server/actors/inspector.js
> @@ +341,5 @@
> >     * Get a single node from the node list.
> >     */
> >    item: method(function(index) {
> > +    let node = this.walker._ref(this.nodeList[index]);
> > +    let newNodes = [node for (node of this.walker.ensurePathToRoot(node))];
> 
> Could we make the remote protocol cognisant of Sets?

Yeah, that should be doable - filed bug 880402.

Comment 5

[Joe Walker [:jwalker]]

I can't apply this on top of 877300 (failures in inspector.js and protocol.js), is there anything I'm missing?

my qser:
866306
877295
877300
878379 -< can't apply

Comment 6

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/d74a6fd28c60

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d74a6fd28c60