878465 - The switch to new WinXP slaves left mozilla-aurora running nothing but talos tests on WinXP

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/?showall=1&tree=Mozilla-Aurora

Unfortunately, unittests aren't optional; aurora is closed.

Comment 1

[Rail Aliiev [:rail]]

Attachment: use xp-ix for m-a

the comment suggest to uplift changes "when Firefox 24 merges in" while 23 is mentioned for other branches. config.py output diff looks good.

Comment 2

[hwine]

Comment on attachment 757013 [details] [diff] [review]
use xp-ix for m-a

Review of attachment 757013 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm - essentially an early deploy to m-a

Comment 3

[Phil Ringnalda (:philor)]

This would probably work okay, but I'm a little leery about doing it since on the trunk we ran unittests on both sets of slaves for several weeks to be sure they would work okay, and on aurora we seem to have either forgotten, and only run talos in parallel, or changed our minds after having decided to not to use xp-ix on aurora23.

Comment 4

[Phil Ringnalda (:philor)]

And the way I would have written that if I'd seen the review comment before seeing it as a mid-air would have been

Not so much an early deploy to m-a as a crash-landing on a branch which is completely unprepared for it. The on-time deploy wouldn't have been "to m-a" but rather "to aurora24" with code which had been running tests on these slaves for weeks before it became visible, and weeks more before it became the only thing.

Comment 5

[Rail Aliiev [:rail]]

Attachment: use xp-rev3 for m-a

An alternative patch. Instead of using ix XP machines we would use rev3 for m-a *unittests* only. I'm not touching talos jobs, they are running on xp-ix. Builder dump diff: https://gist.github.com/rail/5691389

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 757024 [details] [diff] [review]
use xp-rev3 for m-a

Review of attachment 757024 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +1226,2 @@
>  del BRANCHES['mozilla-aurora']['platforms']['win32']['xp-ix']
> +BRANCHES['mozilla-aurora']['platforms']['win32']['talos_slave_platforms'] = ['xp-ix', 'win7-ix', 'win8']

since m-a is not processed by the (evil) loop anymore we need need to tweak some variables:
* We want to remove win7 (rev3) (mimics the loop's "del BRANCHES[branch]['platforms']['win32']['win7']")
* we have to explicitly set talos slave platforms to expected ones (mimics "BRANCHES[branch]['platforms']['win32']['talos_slave_platforms'] = ['xp-ix', 'win7-ix', 'win8']"). I'm not changing talos slave platforms in this patch.

Comment 7

[hwine]

Comment on attachment 757024 [details] [diff] [review]
use xp-rev3 for m-a

lgtm, and I learned 'has_key' is deprecated!

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 757024 [details] [diff] [review]
use xp-rev3 for m-a

https://hg.mozilla.org/build/buildbot-configs/rev/4c3acb2359ea

Comment 9

[Rail Aliiev [:rail]]

I merged it to production, it should be live later today after reconfig.

Comment 10

[Rail Aliiev [:rail]]

in production

Comment 11

[Rail Aliiev [:rail]]

ATM, we have Aurora XP unittests running on rev3 machines (they are hidden though). Using rev3 machines was a safest way to reopen aurora on a Saturday evening. I'll leave the final decision about rev3 vs xp-ix to Armen.

Comment 12

[Armen [:armenzg]]

Thank you and oops!

Comment 13

[Armen [:armenzg]]

Attachment: missed XP iX builders

This adds XP on iX tests back.
This will make us run them side by side.

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 758222 [details] [diff] [review]
missed XP iX builders

       _~
    _~ )_)_~
    )_))_))_)
    _!__!__!_
    \______t/
  ~~~~~~~~~~~~~

Comment 15

[Armen [:armenzg]]

Attachment: catch up with FF23 switch over

This would disable rev3 xp jobs on Aurora.
Once we run the other patch side by side for a day or two.

Comment 16

[Armen [:armenzg]]

Live in production (the first patch).

Comment 17

[Armen [:armenzg]]

Comment on attachment 758223 [details] [diff] [review]
catch up with FF23 switch over

This went live this morning.