878491 - About:home is cut off beneath title bar after OOM kill on non-about:home page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

I'm still seeing bug 869411 in the latest Nightly.

STR:
1) Open Fennec and see about:home
2) Go to google.com
3) Minimize Fennec and cause it to be killed in the background (i.e., open several other apps or use oom-fennec)
4) Reopen Fennec
5) Click back to go to about:home

After doing this, the top of about:home is cut off.

Comment 1

[Brian Nicholson (:bnicholson)]

Bug 869411 did fix the case where the activity is destroyed/recreated while about:home is showing, but I must have forgotten to test the case where about:home isn't visible (as in the STR above). When we leave about:home, we fully remove (not just detach) the fragment, so it is no longer managed by the FragmentManager and its state isn't saved.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Save about:home top padding in BrowserApp instead of AboutHome fragment

Saves the about:home padding state in BrowserApp instead of the AboutHome fragment since the fragment won't save state after being removed. We'll have to end up doing this anyway with our new about:home changes since HomePager isn't a fragment.

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b14bfecb7c34

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b14bfecb7c34

Comment 5

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a931d2bb01cc

Comment 6

[Gabriela [:gaby2300]]

I can verify this is fixed in a Galaxy S2 phone with Android 4.0.3 and the latest Firefox Beta.

Comment 7

[Adrian Tamas (:AdrianT)]

I am unable to reproduce the issue on Firefox Mobile 23 RC and Aurora 24.0a1 2013-07-31 on the Samsung Galaxy R (Android 2.3.4)