878603 - [sms] Always show counter of available characters for current amount of sms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 813689 implemented the SMS character counter which gets shown if there are only 10 or less characters for the first SMS left. It won't go away if you have still 145 characters for the second SMS.

10 characters are nearly always too few characters to complete a started sentence, there are words longer than that e.g. in German. With a counter which is always shown, I have absolutely no problems to write everything I want in one SMS if I want to and use between 158 to 160 characters (the maximum for one SMS), combined by the possibility to choose one's wording.

Android does it similar, but that's also the reason why its SMS app always frustated me.

Comment 1

[Julien Wajsberg [:julienw]]

Ayman, do you think we should try to display the character counter earlier?

Comment 2

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> Ayman, do you think we should try to display the character counter earlier?

Well i am sat here in Berlin, Germany and all the SIMs and Devices I have access to start the countdown from the last 10 characters of the first packet ...and i have certainly never heard of this being a problem for anyone i know here. 

That said if there is enough demand form users I would be happy to underwrite extending the counter's visibility period so that it is triggered when the last (say) 20 characters of the first packet is reached... but we don't want the counter to be permanently visible on the screen as soon as the user starts to type. We are attempting to reduce the amount of data (noise) that is displayed by the message app and having the counter permanently visible is not moving us towards that.

Comment 3

[ankit93040]

Hi Ayman

As per your suggestion, I think its a good idea to notify the user from 20 charaters.

I am taking up with these issue. 

I ll upload the patch soon.

I am not able to assign these issue to myself please assign these issue to me.

Comment 4

[Julien Wajsberg [:julienw]]

Ayman,

I just want to double check with you that we can make this change now, or do you prefer to have some more input first?

Comment 5

[ankit93040]

Instead of "Message" we can easily do "type your Message". 

What else do you expect?

Comment 6

[ankit93040]

Sorry for the above comments.. It's by mistake..

What I have understood is that instead of showing the number of characters available from 10 we should show it from 20.

That is where the progress has stopped.

i have done till that & I think that's a good idea as in completing a message with 10 characters is very difficult.

Comment 7

[Julien Wajsberg [:julienw]]

ankit: please move forward and provide a patch, Ayman will be here this week so I'll be able to ask him directly.

Comment 8

[ankit93040]

Attachment: bug878603.patch

Please have a look at the patch

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8356487 [details] [diff] [review]
bug878603.patch

Review of attachment 8356487 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks good, but you need to:

* update the unit tests (they're failing with your patch)
* create a pull request
* if you want to attach a patch, you need to generate it using `git format-patch -U8 <reference_commit>`

Thanks!

Comment 10

[ankit93040]

Hey Julien

thanks for feedback.

I ll create a pull requset & upload!

Comment 11

[ayman maat :maat]

Comment on attachment 8356487 [details] [diff] [review]
bug878603.patch

Patch looks great to me form a UX PoV. 
Thanks for the work :)

Comment 12

[ankit93040]

thanks for the feedback.

I ll update the unit test & create a pull request for the same.

Comment 13

[sasikala]

Attachment: Pointer to Pull Request

Hi Julienw,

Please find the updated pull request with changes and provide your feedback.

Thanks,

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 8360362 [details]
Pointer to Pull Request

Comments on github

please request review again once it's ready, I'm confident next one will be r+!

Comment 15

[sasikala]

Attachment: Pointer to Pull Request

Hey Julienw,

Please find the updated pull request.

Thanks

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 8360862 [details]
Pointer to Pull Request

r=me thanks !

I'll commit it myself

Comment 17

[Julien Wajsberg [:julienw]]

master: a3464e77aaee2cceb6f0050c203c7c4f53fba3c0

Comment 18

[sasikala]

Thanks Julien