878612 - nsCSSRendering::GetBackgroundLayerRect doesn't pass through the background drawing flags to PrepareBackgroundLayer

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch

This means that nsDisplayBackgroundImage::GetBoundsInternal when it calls GetBackgroundLayerRect can get a different result then when we call PrepareBackgroundLayer later for the actual drawing. This doesn't make sense, they should both do the same thing.

This allows bug 845147 to be green.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: adjust reftest assert count

This one reftest hits the same assert more times because we actually proceed through to the body of nsImageRenderer::PrepareImage when we are just getting the bounds instead of only when we are painting the background image when the sync decode flag is passed in correctly.

The assert is
 ASSERTION: ComputeActualCropRect() should not fail here: 'success', file ../../../layout/base/nsCSSRendering.cpp, line 4284

Comment 2

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78606950ee2e
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cdf2076eb73

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/78606950ee2e
https://hg.mozilla.org/mozilla-central/rev/1cdf2076eb73