878830 - Unable to install any form of web application on the Samsung Galaxy SIV - NS_ERROR_ILLEGAL_VALUE @ nsICryptoHash.init

Status: RESOLVED WORKSFORME

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Aaron Train [:aaronmt]]

STR: http://mozqa.com/webapi-permissions-tests/ -- attempt to install any form of web application


E/GeckoConsole( 5030): [JavaScript Error: "[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsICryptoHash.init]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/Webapps.jsm :: <TOP_LEVEL> :: line 1229"  data: no]" {file: "resource://gre/modules/Webapps.jsm" line: 1229}]

--
Samsung Galaxy SIV (Android 4.2.2)
Nightly (06/03)

Comment 1

[Jason Smith [:jsmith]]

Uh oh. That's bad. That's failing in the computeManifestHash function, which is critical to work in order to have app updates work properly (we use hashes as one mechanism to determine if an update is available or not).

Comment 2

[Aaron Train [:aaronmt]]

Which .so file should I pull from the device and attach here for inspection?

Comment 3

[Wesley Johnston (:wesj)]

Brian, you know who to talk to about this stuff?

Comment 4

[Jason Smith [:jsmith]]

(In reply to Wesley Johnston (:wesj) from comment #3)
> Brian, you know who to talk to about this stuff?

Fabrice would be a good person to ask.

Comment 5

[[:fabrice] Fabrice Desré]

We just do hasher.init(hasher.MD5) so I'm surprised this can fail. Brian, any idea?

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

nsCryptoHash::Init does not return NS_ERROR_ILLEGAL_VALUE, so maybe this is happening at the XPConnect level? For example, is hasher null?

Is there a regression range? Has this ever worked?

This is a bug for FxAndroid only, right?

Comment 7

[Aaron Train [:aaronmt]]

Correction on mozilla-21|22|23 are all unaffected.

Comment 8

[Jason Smith [:jsmith]]

In getting the regression window here, a big first question to ask is that did this ever work when we landed packaged app support on FxAndroid. My hunch that this hasn't ever worked, although I'd like to be not right here.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Jason Smith [:jsmith] from comment #8)
> In getting the regression window here, a big first question to ask is that
> did this ever work when we landed packaged app support on FxAndroid. My
> hunch that this hasn't ever worked, although I'd like to be not right here.

When you ask "did this ever work" are you talking about "for any phone" or do we still think this is limited to the Samsung Galaxy S4?

Comment 10

[Jason Smith [:jsmith]]

(In reply to Mark Finkle (:mfinkle) from comment #9)
> (In reply to Jason Smith [:jsmith] from comment #8)
> > In getting the regression window here, a big first question to ask is that
> > did this ever work when we landed packaged app support on FxAndroid. My
> > hunch that this hasn't ever worked, although I'd like to be not right here.
> 
> When you ask "did this ever work" are you talking about "for any phone" or
> do we still think this is limited to the Samsung Galaxy S4?

I was thinking originally limited to the Samsung Galaxy S4.

Comment 11

[James Hugman [:jhugman] [@jhugman]]

There were hosted app regressions due to the packaged app support on FxAndroid, in bug 856131, but not to do with computeManifestHash.

I was unable to test on the SGS4.

Comment 12

[Aaron Train [:aaronmt]]

Due to complications in on-load decompression and startup crashing, I am unable to run builds from April and May on the SGS4.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

James & Wes: Do either of you have access to a Samsung S 4? If not, we need you too. Also, can we create an add-on or webpage that uses nsICryptoHash to exercise the crash?

Comment 14

[Myk Melez [:myk] [@mykmelez]]

James & Wes: Do either of you have access to a Samsung S 4? If not, we need you too. Also, can we create an add-on or webpage that uses nsICryptoHash to exercise the crash?

Comment 15

[James Hugman [:jhugman] [@jhugman]]

No. Will get an Service Now.

Comment 16

[u279076]

Aaron, is this still a reproducible issue?

Comment 17

[Aaron Train [:aaronmt]]

Over to Flaviu (do you guys have an S4?)

Comment 18

[Flaviu Cos]

I can not reproduce this issue. Tested on all current branches. I can successfully install web apps.
Device used: Samsung Galaxy S4 (Android 4.4.2).

Comment 19

[u279076]

I'm closing this bug based on comment 18. Please reopen if you're able to reproduce the bug. Thank you for testing, Flaviu.