JS debugger: create a RootClient front for talking to root actors

RESOLVED FIXED in Firefox 24

Status

defect
RESOLVED FIXED
6 years ago
10 months ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

Trunk
Firefox 24
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
When communicating with child processes, there will be more than one root actor participating in the connection, so using methods on DebuggerClient instance to talk with root actors is (as one says in academic circles these days) problematic.

We should have a separate RootClient class for sending requests to root actors. For compatibility, DebuggerClient can keep the methods it has now; they can forward to the connection's original root actor.
(Assignee)

Comment 1

6 years ago
Tests seem to pass.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Blocks: 797627
(Assignee)

Updated

6 years ago
Blocks: 878958
(Assignee)

Updated

6 years ago
No longer blocks: 797627
(Assignee)

Comment 3

6 years ago
Attachment #757495 - Attachment is obsolete: true
Attachment #758919 - Flags: review?(dcamp)
(Assignee)

Updated

6 years ago
Blocks: 874753
No longer blocks: 878958

Updated

6 years ago
Attachment #758919 - Flags: review?(dcamp) → review+
(Assignee)

Comment 4

6 years ago
Updated; minor changes. Carrying over r=dcamp.
Attachment #758919 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1edee344c98
Flags: in-testsuite-
Target Milestone: --- → Firefox 24
https://hg.mozilla.org/mozilla-central/rev/d1edee344c98
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.