Closed Bug 878901 Opened 8 years ago Closed 8 years ago

JS debugger: create a RootClient front for talking to root actors

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: jimb, Assigned: jimb)

References

Details

Attachments

(1 file, 2 obsolete files)

When communicating with child processes, there will be more than one root actor participating in the connection, so using methods on DebuggerClient instance to talk with root actors is (as one says in academic circles these days) problematic.

We should have a separate RootClient class for sending requests to root actors. For compatibility, DebuggerClient can keep the methods it has now; they can forward to the connection's original root actor.
Tests seem to pass.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Blocks: 797627
Blocks: 878958
No longer blocks: 797627
Attachment #757495 - Attachment is obsolete: true
Attachment #758919 - Flags: review?(dcamp)
Blocks: 874753
No longer blocks: 878958
Attachment #758919 - Flags: review?(dcamp) → review+
Updated; minor changes. Carrying over r=dcamp.
Attachment #758919 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1edee344c98
Flags: in-testsuite-
Target Milestone: --- → Firefox 24
https://hg.mozilla.org/mozilla-central/rev/d1edee344c98
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.