879029 - js/xpconnect/src/nsCxPusher.cpp:120:16 [-Wunused-variable] unused variable 'xpc'

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning:
{
js/xpconnect/src/nsCxPusher.cpp:120:16 [-Wunused-variable] unused variable 'xpc'
}

which was introduced by:
 http://hg.mozilla.org/mozilla-central/rev/eea9248f39a9#l15.10

Basically, we used to just have a sanity-check for GetXPConnect(), and if it returned null, we'd intentionally (safely) crash.  Now it's infallible, and the safe crash has been removed, and the infallible (unused) XPConnect() call is still straggling there. (and can be removed)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: remove the variable

Here's the patch, which just removes the variable 'xpc'.

(Side note: the "xpc" prefix in "xpc::IsJSContextOnStack" a few lines down is a reference to the xpc namespace, not a reference to this removed xpc variable.)

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fea1f917297

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0fea1f917297