Closed Bug 879029 Opened 6 years ago Closed 6 years ago

js/xpconnect/src/nsCxPusher.cpp:120:16 [-Wunused-variable] unused variable 'xpc'

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning:
{
js/xpconnect/src/nsCxPusher.cpp:120:16 [-Wunused-variable] unused variable 'xpc'
}

which was introduced by:
 http://hg.mozilla.org/mozilla-central/rev/eea9248f39a9#l15.10

Basically, we used to just have a sanity-check for GetXPConnect(), and if it returned null, we'd intentionally (safely) crash.  Now it's infallible, and the safe crash has been removed, and the infallible (unused) XPConnect() call is still straggling there. (and can be removed)
Here's the patch, which just removes the variable 'xpc'.

(Side note: the "xpc" prefix in "xpc::IsJSContextOnStack" a few lines down is a reference to the xpc namespace, not a reference to this removed xpc variable.)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #757659 - Flags: review?(bobbyholley+bmo)
Attachment #757659 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/0fea1f917297
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.