879055 - anywordssubstr search returns incorrect results

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P1)

Description

[Simon Green]

The following query:
https://landfill.bugzilla.org/bugzilla-4.4-branch/buglist.cgi?bug_id=19829&bug_id_type=anyexact&f1=flagtypes.name&list_id=50301&o1=anywordssubstr&query_format=advanced&v1=blocker%2B%2Cfoo%2B&debug=1

returns bug 19829, despite it having the flags blocker? and foo?

This is due to an error in the SQL that Bugzilla::Search generates.

(EXISTS ( SELECT 1 FROM bugs bugs_2 LEFT JOIN attachments AS attachments_2 ON bugs_2.bug_id = attachments_2.bug_id LEFT JOIN flags AS flags_2 ON bugs_2.bug_id = flags_2.bug_id AND (flags_2.attach_id = attachments_2.attach_id OR flags_2.attach_id IS NULL) LEFT JOIN flagtypes AS flagtypes_2 ON flags_2.type_id = flagtypes_2.id WHERE bugs_2.bug_id = bugs.bug_id AND INSTR(CONCAT(flagtypes_2.name, flags_2.status), 'blocker+') > 0 OR INSTR(CONCAT(flagtypes_2.name, flags_2.status), 'foo+') > 0 ))

AND has precedence over OR ( http://dev.mysql.com/doc/refman/5.1/en/operator-precedence.html ), so as long as ANY bug has foo+ as a flag, the whole block above will always return true.

The solution is to wrap some parenthesis around the last two statements.

Comment 1

[Simon Green]

Attachment: v1 patch

Comment 2

[:glob ✱]

Comment on attachment 757733 [details] [diff] [review]
v1 patch

r=glob

Comment 3

[Frédéric Buclin]

I will let glob commit this patch.

Comment 4

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Search.pm
Committed revision 8629.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Search.pm
Committed revision 8564.