879092 - Have different runtime abort messages for the different error types (e.g. MsgNotKnown, MsgNotAllowed, MsgPayloadError etc.)

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Looking at http://hg.mozilla.org/mozilla-central/annotate/8b1bfcf0ce6e/dom/ipc/ContentChild.cpp#l946 :

void
ContentChild::ProcessingError(Result what)
{
    switch (what) {
    case MsgDropped:
        QuickExit();

    case MsgNotKnown:
    case MsgNotAllowed:
    case MsgPayloadError:
    case MsgProcessingError:
    case MsgRouteError:
    case MsgValueError:
        NS_RUNTIMEABORT("aborting because of fatal error");

    default:
        NS_RUNTIMEABORT("not reached");
    }
}

It seems that all of the error types (e.g. MsgNotKnown, MsgNotAllowed, MsgPayloadError etc.) are lumped into the same runtime abort message. This makes bugs like bug 867025 and bug 878366 difficult to debug.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(this came after discussion w/dveditz on bug 878366)

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Moving to Core: IPC.

Comment 3

[Justin Lebar (not reading bugmail)]

I'd be happy to take a patch here.

Comment 4

[Justin Lebar (not reading bugmail)]

This is not a regression.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v0

I'm not sure if this is the best approach.

Comment 6

[Justin Lebar (not reading bugmail)]

Comment on attachment 757771 [details] [diff] [review]
patch v0

This is fine with me!

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15a49c8c7c37

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/15a49c8c7c37