Closed
Bug 879092
Opened 12 years ago
Closed 12 years ago
Have different runtime abort messages for the different error types (e.g. MsgNotKnown, MsgNotAllowed, MsgPayloadError etc.)
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: gkw, Assigned: gkw)
References
Details
Attachments
(1 file)
1.11 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
Looking at http://hg.mozilla.org/mozilla-central/annotate/8b1bfcf0ce6e/dom/ipc/ContentChild.cpp#l946 :
void
ContentChild::ProcessingError(Result what)
{
switch (what) {
case MsgDropped:
QuickExit();
case MsgNotKnown:
case MsgNotAllowed:
case MsgPayloadError:
case MsgProcessingError:
case MsgRouteError:
case MsgValueError:
NS_RUNTIMEABORT("aborting because of fatal error");
default:
NS_RUNTIMEABORT("not reached");
}
}
It seems that all of the error types (e.g. MsgNotKnown, MsgNotAllowed, MsgPayloadError etc.) are lumped into the same runtime abort message. This makes bugs like bug 867025 and bug 878366 difficult to debug.
![]() |
Assignee | |
Comment 1•12 years ago
|
||
(this came after discussion w/dveditz on bug 878366)
![]() |
Assignee | |
Comment 2•12 years ago
|
||
Moving to Core: IPC.
Component: General → IPC
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Comment 3•12 years ago
|
||
I'd be happy to take a patch here.
![]() |
Assignee | |
Comment 5•12 years ago
|
||
I'm not sure if this is the best approach.
Assignee: nobody → gary
Status: NEW → ASSIGNED
Attachment #757771 -
Flags: feedback?(justin.lebar+bug)
Comment 6•12 years ago
|
||
Comment on attachment 757771 [details] [diff] [review]
patch v0
This is fine with me!
Attachment #757771 -
Flags: feedback?(justin.lebar+bug) → review+
![]() |
Assignee | |
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•