879098 - UX branch failures in browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Matthew N. [:MattN]]

15:42:00  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js | The window title for about:blank is correct (outside private browsing mode) - Got UX, expected New Tab
15:42:00  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js | The window title for about:blank detached tab is correct (outside private browsing mode) - Got UX, expected New Tab
15:42:05  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js | The window title for about:blank is correct (inside private browsing mode) - Got UX - (Private Browsing), expected New Tab - (Private Browsing)
15:42:05  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js | The window title for about:blank detached tab is correct (inside private browsing mode) - Got UX - (Private Browsing), expected New Tab - (Private Browsing)
15:42:08  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js | The window title for about:privatebrowsing is correct (inside private browsing mode) - Got UX - (Private Browsing), expected New Tab - (Private Browsing)
15:42:09  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js | The window title for about:privatebrowsing detached tab is correct (inside private browsing mode) - Got UX - (Private Browsing), expected New Tab - (Private Browsing)

Started with this push: https://hg.mozilla.org/projects/ux/pushloghtml?changeset=ccd9c2be155c

https://tbpl.mozilla.org/?tree=UX&rev=ccd9c2be155c

Comment 1

[:Gijs (he/him)]

Backed out https://hg.mozilla.org/projects/ux/rev/e878799f7d5a after locally verifying it's that test which influences the (invisible!) page titles. :-(

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I wonder if it's happening because the new test isn't cleaning up in time before the next one executes?

Comment 3

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] from comment #2)
> I wonder if it's happening because the new test isn't cleaning up in time
> before the next one executes?

So this is some weird interaction between the test for bug 878452, privatebrowsing's browser_privatebrowsing_placesTitleNoUpdate.js and browser_privatebrowsing_windowtitle.js . Taking any one of these out solves the problem. :-\

That's about where I'm at, although I did find a bug with how reset() outside of customization mode and the overflowable navbar interact. After running the test from bug 878452, this results in the chevron being displayed (where it wasn't for previous tests). I don't (yet?) see how that could be related though.

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Jared Wein [:jaws] from comment #2)
> > I wonder if it's happening because the new test isn't cleaning up in time
> > before the next one executes?

Oh, and to more specifically answer your question... no. A timeout doesn't help resolve this, and the promises + yield + Task.jsm seem to take care of this fairly well. There's an actual problem with our code that breaks stuff later on, it seems. :-\

Comment 5

[:Gijs (he/him)]

Attachment: Fix failures

This got r+ from mconley over IRC, yay.

Comment 6

[:Gijs (he/him)]

Pushed: https://hg.mozilla.org/projects/ux/rev/50122ea0f5b3

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/50122ea0f5b3