Closed Bug 879165 Opened 12 years ago Closed 12 years ago

newtab class used in templates should be removed as it is no longer used and breaks 2 strings for locales

Categories

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Product:
Firefox Health Report Graveyard
Component:
Web: Health Report
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: pascalc, Assigned: espressive)

References

Details

So as to solve bug 870631, we set a target="_blank" to the page in https://github.com/mozilla/fhr-jelly/commit/1bcbbfa77137c49f5428557ee6eadb9983549b37 but this commit didn't remove the class='newtab' in the template file. Learn how we handle your data in our <a href="%(privacy_url)s">privacy policy.</a> Your Health Report data will also be removed from Mozilla's servers. Learn more in our <a href="%(privacy_url)s">privacy policy. Since the template has class='newtab' in the links and not the lang files, the strings are displayed in English. The right fix is to remove the class use in the template since it is not used in the end, otherwise we will have to update all the lang files. Laura, is that ok for you?
Blocks: 851137
Assignee: nobody → sneethling
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
QA verified on dev, class='newtab' has been removed from the template
Status: RESOLVED → VERIFIED
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.