Closed
Bug 879172
Opened 9 years ago
Closed 9 years ago
crash in mozilla::MediaCacheStream::SetReadMode @ libmmparser.so on Sony Ericsson LT26 running JB 4.1
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: scoobidiver, Assigned: bjacob)
Details
(Keywords: crash, qawanted, topcrash, Whiteboard: [native-crash])
Crash Data
Attachments
(2 files)
978 bytes,
patch
|
joe
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
978 bytes,
text/plain
|
Details |
It's #44 crasher in 21.0 and #26 in 22.0b3. It first showed up on April 28. Here is the breakdown per device: Sony Ericsson LT26i 130 Sony Ericsson LT26w 19 Sony Ericsson LT26ii 11 Sony Ericsson LT28h 2 Sony devices are blocklisted for Stagefright on JB (bug 845734) but Sony Ericsson ones are not (.Equals instead of .Find). See bp-dc2459be-ec55-4682-b70c-befb72130603. Signature @0x0 | libmmparser.so@0x8cc72 More Reports Search UUID 3df3b5f1-b326-4139-9f9e-d1edc2130604 Date Processed 2013-06-04 02:53:14 Uptime 224 Last Crash 3.9 minutes before submission Install Age 4.0 days since version was first installed. Install Time 2013-05-31 02:21:08 Product FennecAndroid Version 22.0 Build ID 20130528175857 Release Channel beta OS Android OS Version 0.0.0 Linux 3.4.0+1.0.21100-313065-g1ccebb5-00165-g78362b4 #1 SMP PREEMPT Wed Apr 24 10:01:32 2013 armv7l SEMC/LT26w_1266-2032/LT26w:4.1.2/6.2.B.0.200/N7__zg:user/release-keys Build Architecture arm Build Architecture Info ARMv0 Crash Reason SIGSEGV Crash Address 0x0 App Notes AdapterDescription: 'Qualcomm -- Adreno (TM) 220 -- OpenGL ES 2.0 V@6.0 AU@1.04.01.01.06.041 (CL@) -- Model: LT26w, Product: LT26w_1266-2032, Manufacturer: Sony Ericsson, Hardware: semc' EGL? EGL+ GL Context? GL Context+ GL Layers? GL Layers+ Sony Ericsson LT26w SEMC/LT26w_1266-2032/LT26w:4.1.2/6.2.B.0.200/N7__zg:user/release-keys Processor Notes sp-processor05_phx1_mozilla_com_19323:2012; exploitability tool: ERROR: unable to analyze dump EMCheckCompatibility True Adapter Vendor ID Qualcomm Adapter Device ID Adreno (TM) 220 Device Sony Ericsson LT26w Android API Version 16 (REL) Android CPU ABI armeabi-v7a Frame Module Signature Source 0 @0x0 1 libmmparser.so libmmparser.so@0x8cc72 2 linker linker@0x4e1d 3 libstagefright.so libstagefright.so@0xfe6bf 4 linker linker@0x14bc6 5 linker linker@0x1489e 6 linker linker@0x50e3 7 libc.so libc.so@0x15699 8 libmmparser.so libmmparser.so@0x4bf43 9 libomxplugin.so (deleted) libomxplugin.so @0x23bf 10 libstagefright.so libstagefright.so@0x688e7 11 libomxplugin.so (deleted) libomxplugin.so @0x23bf 12 libc.so libc.so@0x17247 13 libstdc++.so libstdc++.so@0x8fd 14 libstagefright.so libstagefright.so@0x67d49 15 libstagefright.so libstagefright.so@0x67e6d 16 libstagefright.so libstagefright.so@0x7e147 17 libxul.so mozilla::MediaCacheStream::SetReadMode content/media/MediaCache.cpp:2018 18 libomxplugin.so (deleted) libomxplugin.so @0x1dad More reports at: https://crash-stats.mozilla.com/report/list?signature=%400x0+|+libmmparser.so%400x8cc72
![]() |
||
Comment 1•9 years ago
|
||
This is rising fast in 21 crash stats on Android, #18 in yesterday's data.
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 2•9 years ago
|
||
It's #12 crasher in 21.0 and #14 in 22.0b4. The patch consist to replace: cManufacturer.Equals("Sony", nsCaseInsensitiveCStringComparator()); by cManufacturer.Find("Sony", true) != -1;
tracking-firefox22:
--- → ?
Comment 3•9 years ago
|
||
(In reply to Robert Kaiser (:kairo@mozilla.com) [away until early June] from comment #1) > This is rising fast in 21 crash stats on Android, #18 in yesterday's data. This is due to http://au.ibtimes.com/articles/476496/20130609/sony-xperia-s-new-official-android-4.htm
Comment 4•9 years ago
|
||
bjacob - does Scoobidiver's suggestion in Comment 2 sound like the right path forward?
Assignee: nobody → bjacob
Assignee | ||
Comment 5•9 years ago
|
||
Yup, it's correct, even correctly has the != -1 that I mistakenly forgot recently causing a lot of trouble :) r+!
Assignee | ||
Comment 6•9 years ago
|
||
...except for one thing: we want to keep using a case-insensitive comparison. I just grepped through some crash reports, and a very small minority have 'sony' all lowercase, even in the Manufacturer field.
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #761067 -
Flags: review?(joe)
Updated•9 years ago
|
Attachment #761067 -
Flags: review?(joe) → review+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f4975ba986 Scoobidiver: modulo the case-insensitive part, this is basically your patch. Next time don't hesitate to submit a patch and/or ask for help with that (say, on IRC #developers or #gfx).
Target Milestone: --- → mozilla24
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 761067 [details] [diff] [review] match Sony as a substring, case-insensitive [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a, driver bug we were not yet blacklisting User impact if declined: topcrasher on android Testing completed (on m-c, etc.): m-i Risk to taking this patch (and alternatives if risky): no risk thanks to having carefully read and re-read this one-line patch String or IDL/UUID changes made by this patch: none
Attachment #761067 -
Flags: approval-mozilla-beta?
Attachment #761067 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 10•9 years ago
|
||
(In reply to Benoit Jacob [:bjacob] from comment #8) > Next time don't hesitate to submit a patch and/or ask for help with that It's not easy to submit a patch on Windows according to https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Assignee | ||
Comment 11•9 years ago
|
||
The only Windows-specific issue is line endings; it is just a matter of telling your text editor to generate Unix-style line endings. There is no other windows-specific issue that I know (and I have generated patches under Windows). If a wiki page suggests otherwise, it may need to be clarified.
Updated•9 years ago
|
Attachment #761067 -
Flags: approval-mozilla-beta?
Attachment #761067 -
Flags: approval-mozilla-beta+
Attachment #761067 -
Flags: approval-mozilla-aurora?
Attachment #761067 -
Flags: approval-mozilla-aurora+
Comment 12•9 years ago
|
||
We'll want to do some spot checking of this change to make sure we didn't disable more than we intended, Aaron.
Comment 13•9 years ago
|
||
Backed out for Android bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/bcf3b603a662 https://tbpl.mozilla.org/php/getParsedLog.php?id=24021356&tree=Mozilla-Inbound
Assignee | ||
Comment 14•9 years ago
|
||
it turns out that while nsCString::Find on a nsCString takes a Comparator, nsCString::Find on a const char * wants a |bool ignoreCase| !!
Assignee | ||
Comment 15•9 years ago
|
||
As a result of this stupid compiler error, the tree has been closed, and I am not allowed to re-land on CLOSED TREE. This is the last time I rush a last minute blocklist fix. Future ones will go on tryserver no matter how urgent they may be.
Assignee | ||
Comment 16•9 years ago
|
||
Which means don't even bother asking me for a same-day fix.
Assignee | ||
Comment 17•9 years ago
|
||
pushed on CLOSED TREE with permission: https://hg.mozilla.org/integration/mozilla-inbound/rev/34d230cab71c
Assignee | ||
Comment 18•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/fff3cbfd6857 http://hg.mozilla.org/releases/mozilla-beta/rev/d172de3a2173
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/34d230cab71c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 20•9 years ago
|
||
I've updated https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers accordingly.
Comment 21•9 years ago
|
||
This was filed against Android 4.1, patched against Android 4.2 (http://mxr.mozilla.org/mozilla-beta/source/widget/android/GfxInfo.cpp#464) and documented against Android 4.1 - is this a mistake, should the check be in the if/else block above?
Comment 22•9 years ago
|
||
nevermind I see how CompareVersions()'s works here in this case
Comment 23•9 years ago
|
||
Do those approvals mean I can just land?
Comment 24•9 years ago
|
||
Oops, wrong bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•