Closed Bug 879185 Opened 8 years ago Closed 7 years ago

Netmonitor filterbuttons: button.setAttribute("checked", ""); --> Should be set to "true".

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: alfredkayser, Assigned: vporof)

References

Details

Attachments

(1 file, 1 obsolete file)

When setting checked on buttons, one must set checked to "true" to get the right styling applied on them.
Also the "all" button should get the status "checked"="true", when that is selected (or no other filters are enabled).
Priority: -- → P3
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #764647 - Flags: review?(rcampbell)
Attached patch v1Splinter Review
Forgot a qref. Sorry about the double r?.
Attachment #764647 - Attachment is obsolete: true
Attachment #764647 - Flags: review?(rcampbell)
Attachment #764649 - Flags: review?(rcampbell)
Attachment #764649 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/c0b09f28ad87
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.