Closed
Bug 879295
Opened 11 years ago
Closed 11 years ago
Hard-coded string for Zoom controls in CustomizableWidgets.jsm
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: jaws, Assigned: mikedeboer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M6])
Attachments
(1 file, 1 obsolete file)
|
1.97 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/projects/ux/annotate/7a4f2f5b3c6b/browser/components/customizableui/src/CustomizableWidgets.jsm#l269 The text "Zoom Controls" is hard-coded to English. It's possible that this line can be deleted since there are other places where the title can get set.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #757969 -
Flags: review?(jaws)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Thanks for catching this! I completely looked over it while working on bug 868433!
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 757969 [details] [diff] [review] Switch hardcoded strings to use localized alternatives Review of attachment 757969 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #757969 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Patch ready to land on UX. Carrying over r=jaws Thanks!
Attachment #757969 -
Attachment is obsolete: true
Attachment #757975 -
Flags: review+
|
||
Comment 5•11 years ago
|
||
Pushed, https://hg.mozilla.org/projects/ux/rev/558fa738a898
Whiteboard: [Australis:M?] → [Australis:M6][fixed-in-ux]
|
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/558fa738a898
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M6][fixed-in-ux] → [Australis:M6]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•