879304 - WebGL's 32 warnings per context limit should be configurable by a preference

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Generating JS warnings is slow. WebGL scenes that generate many can be slow because of that. For that reason, we have placed a limit of 32 warnings per WebGL context, after which we stop generating WebGL warnings.

This is in content/canvas/src/WebGLContext.h:

    bool ShouldGenerateWarnings() const {
        return mAlreadyGeneratedWarnings < 32;
    }

This '32' here should be configurable by a preference (something in about:config).

Preferences can be accessed like we do in WebGLContext::SetDimensions in WebGLContext.cpp (search for "webgl.force-enabled"). Please add a new integer preference, webgl.max-warnings-per-context, defaulting to 32, and use it there.

Adding new preferences is done by editing this file:

  modules/libpref/src/init/all.js

Comment 1

[Guillaume Abadie]

Attachment: bug 879304 fix : adding prefrence var "webgl.max-warnings-per-context"

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 758072 [details] [diff] [review]
bug 879304 fix : adding prefrence var "webgl.max-warnings-per-context"

Review of attachment 758072 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a couple of style nits

::: content/canvas/src/WebGLContext.cpp
@@ +189,5 @@
>  
>      mAlreadyGeneratedWarnings = 0;
>      mAlreadyWarnedAboutFakeVertexAttrib0 = false;
> +    Preferences::GetInt("webgl.max-warnings-per-context",&mMaxWarnings);
> +    if ( mMaxWarnings < -1 )

style

::: content/canvas/src/WebGLContext.h
@@ +1140,5 @@
>      bool ShouldGenerateWarnings() const {
> +        if (mMaxWarnings == -1) {
> +            return true;
> +        }
> +        

trailing whitespace

Comment 3

[Guillaume Abadie]

Attachment: patch for landing

carrying forward r+ from bjacob

Comment 4

[Guillaume Abadie]

Attachment: patch with correct usage of Preference API

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 758111 [details] [diff] [review]
patch with correct usage of Preference API

Review of attachment 758111 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks ;-)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

FYI, for a bug with a single patch, you can just use the checkin-needed keyword instead of setting checkin? on the individual patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c2a4b9971c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f8c2a4b9971c