Closed
Bug 879477
Opened 11 years ago
Closed 11 years ago
PeerConnectionImpl should use consistent identifiers in logging
Categories
(Core :: WebRTC: Signaling, enhancement, P4)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: abr, Assigned: abr)
Details
(Whiteboard: [WebRTC], [blocking-webrtc-][qa-])
Attachments
(1 file)
|
3.98 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
Currently, the logging in PeerConnectionImpl uses "this" (formatted as a pointer) in some places, and mHandle in others for identifying itself. This makes reading logs somewhat more difficult than necessary. These should be harmonized, ideally using the PC handle rather than its pointer.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #760280 -
Flags: review?(ekr)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 760280 [details] [diff] [review] Update PC to use mHandle instead of (void *) this in logging Review of attachment 760280 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #760280 -
Flags: review?(ekr) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ef0e47cddd4
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7ef0e47cddd4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•11 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•