879479 - Reviews should not be visible for unavailable apps

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

Access a pending app or an app that you can't see in your particular region:

    https://marketplace.firefox.com/app/marketplace

Notice that you can still see the reviews. The API should be doing the same checks that we do for the app resources.

Comment 1

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/36e124dea7

Comment 2

[krupa raj[:krupa]]

STR:
1. Change your region to Colombia
2. Find an app which is not supported for Colombia like Beatlab- https://marketplace-dev.allizom.org/app/beatlab/ratings

Ratings page is still accessible.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

I had filed this bug for the detail page. Allen, if you could though, fix the bug Krupa found too.

I don't think it's acceptable to show "Review not yet rated" in Fireplace though. http://f.cl.ly/items/3t2r0r1e1d28331x2U2C/Screen%20Shot%202013-06-18%20at%201.27.57%20PM.png
Davor, could you fix that in Fireplace?

Comment 4

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/705001e

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> I don't think it's acceptable to show "Review not yet rated" in Fireplace
> though.
> http://f.cl.ly/items/3t2r0r1e1d28331x2U2C/Screen%20Shot%202013-06-
> 18%20at%201.27.57%20PM.png
> Davor, could you fix that in Fireplace?

This part was not fixed. Please fix or file a new bug.

Comment 6

[Allen Short [:ashort]]

filed bug 885143

Comment 7

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF24 (Win 7)
Postfix screencast http://screencast.com/t/ARS0qiKpY
Closing bug.