879519 - Create conversation-thread models

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

ActivityLog, AppLog, CommentLog do not serve our purposes. And we will need to backfill the data from those models into these new ones.

Feel free to get creative, but here is how the models could look:

Thread
id       NOT NULL
app      NOT NULL
version  NULL
created  NOT NULL

CC
id       NOT NULL
thread   NOT NULL
user     NOT NULL
created  NOT NULL

Note
id                          NOT NULL
thread                      NOT NULL
author                      NOT NULL
type                        NOT NULL  Approval, Rejection, Disabled, MoreInfo, Escalation, ReviewerComment, Resubmission
permission_public           NULL
permission_developer        NULL
permission_reviewer         NULL
permission_senior_reviewer  NULL
permission_mozilla_contact  NULL
permission_staff            NULL
created                     NOT NULL
modified                    NOT NULL

Token
id       NOT NULL
thread   NOT NULL
user     NOT NULL
uuid     NOT NULL
created  NOT NULL

Token should have a defined expiration. The expiration for reviewers should be lower than for non-reviewers. Tokens should also have a counter for the maximum number of times they can be used.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Also:

Note
body     NULL

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Amending:

Thread
id                               NOT NULL
app                              NOT NULL
version                          NULL
read_permission_developer        NULL
read_permission_reviewer         NULL
read_permission_senior_reviewer  NULL
read_permission_mozilla_contact  NULL
read_permission_staff            NULL
created                          NOT NULL

CC
id       NOT NULL
thread   NOT NULL
user     NOT NULL
created  NOT NULL

Note
id                          NOT NULL
thread                      NOT NULL
author                      NOT NULL
body                        NULL  Translated Field
type                        NOT NULL  Approval, Rejection, Disabled, MoreInfo, Escalation, ReviewerComment, Resubmission
created                     NOT NULL
modified                    NOT NULL

Token
id       NOT NULL
thread   NOT NULL
user     NOT NULL
uuid     NOT NULL
created  NOT NULL

Any user who has access to read a thread can post a note for that thread.

Comment 3

[Ashish Dubey [:ashish_d]]

Here is a rough draft: https://github.com/dash1291/zamboni/commit/a22e6837e18ad077a81a1bd1e8bb4160133a3164

Note:
We may want to confirm the values for expiration time and max use count for a thread token.

Comment 4

[Ashish Dubey [:ashish_d]]

https://github.com/mozilla/zamboni/commit/89869e2b22a

Comment 5

[Victor Carciu]

Can you please add some STRs here or mark it as [qa-] if no QA is needed here?