879523 - Remote the SelectorSearch

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

Attachment: WIP

This WIP doesn't do autocompletion yet.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

I'll file a followup to port the autocompletion.

Comment 2

[Girish Sharma [:Optimizer]]

Comment on attachment 766736 [details] [diff] [review]
v1

Review of attachment 766736 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. Although I am just assuming that the tests pass.

::: browser/devtools/inspector/selector-search.js
@@ +217,5 @@
> +    this._lastQuery = this.walker.querySelectorAll(this.walker.rootNode, query).then(list => {
> +      return list;
> +    }, (err) => {
> +      // Failures are ok here, just use a null item list;
> +      return null;l

too much nullness

@@ +230,5 @@
>  
> +      // Value has changed since we started this request, we're done.
> +      if (query != this.searchBox.value) {
> +        return;
> +      }

umm, again ?

Comment 3

[Dave Camp (:dcamp)]

(In reply to Girish Sharma [:Optimizer] from comment #2)

> 
> @@ +230,5 @@
> >  
> > +      // Value has changed since we started this request, we're done.
> > +      if (query != this.searchBox.value) {
> > +        return;
> > +      }
> 
> umm, again ?

Yeah, because we do two async requests, so the searchbox might have changed in the meantime either time.

Comment 4

[Dave Camp (:dcamp)]

Attachment: v2

I take that back.  New version.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/40fcf0ac7aba