Closed
Bug 879540
Opened 12 years ago
Closed 12 years ago
Remove "random" annotations from flexbox/reftest.list for tests that use tables as flex items
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
2.63 KB,
patch
|
Details | Diff | Splinter Review |
We've got two reftests that have tables as flex items that are currently marked as "random" since they only pass if the flexbox pref is toggled *at startup time*, when we parse ua.css (since table flex items require a special "align-self: inherit" rule in ua.css). So unlike the rest of the tests in that directory, these two tests require more than simply toggling the pref on at runtime.
Since flexbox is enabled by default now (ever since bug 841876 landed), and it looks like that's sticking, we can remove these "random" annotations and actually measure whether these tests pass.
| Assignee | ||
Comment 1•12 years ago
|
||
Here's the (trivial, reftest.list-only) patch.
Try run, to be sure these tests do actually pass reliably:
https://tbpl.mozilla.org/?tree=Try&rev=e690e4db7c5e
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•12 years ago
|
||
Try looks good -- pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/59c9d4349de6
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•