Closed Bug 879595 Opened 11 years ago Closed 11 years ago

Middle section of OS X tabs missing texture, just a plain gradient

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: Dolske, Assigned: mstange)

References

Details

(Whiteboard: [Australis:M7])

Attachments

(1 file, 3 obsolete files)

(Filed from Australis tabs ui-review #1)

OS X -- selected tab, background of the middle of the tab appears to be a gradient, whereas ends (and the navbar underneath) have a light noise texture. Hard to see. http://cl.ly/image/2F0b3Q3e0R14

(This is from my Retina MBP, if that matters)
Blocks: australis-tabs-osx
No longer blocks: australis-tabs
Hardware: x86 → All
Not taking this for M7.
Attached patch v1 (obsolete) — Splinter Review
This still needs testing on Windows and Linux. On Mac it seems to work fine.
Attachment #761416 - Flags: review?(mnoorenberghe+bmo)
I've had to remove the noise texture from tab-stroke*.png and tab-active-middle*.png so that the background matched properly between the tab parts and the navbar. Before landing, it would probably be good if Stephen exported his source images again, without the noise part.
Attached patch v2 (obsolete) — Splinter Review
fixes HiDPI
Attachment #761416 - Attachment is obsolete: true
Attachment #761416 - Flags: review?(mnoorenberghe+bmo)
Attachment #761425 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 761425 [details] [diff] [review]
v2

s/fgTabRepeatedOverlay/fgTabNoise/? I can't think of a use for this other than a noise texture, and "repeated overlay" is ambiguous since fgTabTexture is also an overlay and whether it's repeated or not is meaningless. Confusingly, both images are also textures, so it might even make sense to rename the latter to fgTabGradient...
Attached patch v3 (obsolete) — Splinter Review
Renamed to fgTabNoise. I don't think renaming fgTabTexture to fgTabGradient belongs in this patch.
Attachment #761425 - Attachment is obsolete: true
Attachment #761425 - Flags: review?(mnoorenberghe+bmo)
Attachment #761436 - Flags: review?(dao)
(In reply to Markus Stange from comment #6)
> Created attachment 761436 [details] [diff] [review]
> v3
> 
> Renamed to fgTabNoise. I don't think renaming fgTabTexture to fgTabGradient
> belongs in this patch.

It's directly related to your changes, as adding a second texture-like graphic makes the term ambiguous where it used to be unambiguous. However, it's ok to handle this in a followup bug. Please file it then.
I've filed it as bug 882293.
Did you test this with lightweight themes? They also use browser-lightweightTheme.css.

It's not clear to me why we can't just have the same texture in the existing images? Was the problem that the texture was different? Another option was that it was not tiling properly and instead was being stretched. Less images should be more performant and I thought they all had textures anyways.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attached patch v4Splinter Review
Huh. This works just as well. Don't know what I was seeing before..
Attachment #761436 - Attachment is obsolete: true
Attachment #761436 - Flags: review?(dao)
Attachment #761786 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 761786 [details] [diff] [review]
v4

Review of attachment 761786 [details] [diff] [review]:
-----------------------------------------------------------------

These are two things that I suspected were the problem. The 92% was fine before we had the proper tab height.

::: browser/themes/osx/shared.inc
@@ +1,4 @@
>  %include ../../../toolkit/themes/osx/global/shared.inc
>  %include ../shared/browser.inc
>  
> +%define fgTabTexture linear-gradient(transparent, transparent 2px, hsla(0,0%,100%,0.6) 2px, hsla(0,0%,100%,0.6) 3px, hsl(0,0%,99%) 3px, hsl(0,0%,93%))

Note for the future: This now needs to be 93% because the bottom of the tab now overlaps the nav-bar an extra pixel (bug 858089) compared to before. This color now exactly matches the colour [hsl(0,0%,93%)] used on #nav-bar in osx/browser.css.

We could make this a define although it's only used in these two places so I don't feel strongly about it.
Attachment #761786 - Flags: review?(mnoorenberghe+bmo) → review+
Whiteboard: [Australis:M?] → [Australis:M7]
https://hg.mozilla.org/projects/ux/rev/6a1067f3c251
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/6a1067f3c251
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: