879623 - Missing about:home thumbnails when enabling 'Don't Keep Activities'

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Aaron Train [:aaronmt]]

Attachment: Screenshot (Nightly 06/04)

Not reproducible. Merely launched Nightly this evening on my HTC One. See screenshot.

E/GeckoConsole(21140): [JavaScript Error: "TypeError: this.selectedTab is null" {file: "chrome://browser/content/browser.js" line: 1472}]

--
HTC One (Android 4.1)
Nightly (06/04)

Comment 1

[Teodora Vermesan (:TeoVermesan)]

I'm not able to reproduce this on Firefox for Android 24.0a1 (2013-06-05) using HTC One S (Android 4.1.1)

Comment 2

[Teodora Vermesan (:TeoVermesan)]

I can reproduce this on Samsung Galaxy Nexus (Android 4.1.1) 
Steps to reproduce:
1. Open Firefox
2. Go to Settings
3. Tap the back button.

Note. 
- if you visit a page and go back to about:home, the page looks fine
- if you go to settings again and tap the back button, the about:home thumbnails are missing

Comment 3

[Aaron Train [:aaronmt]]

Those steps don't seem to do the trick for me.

Comment 4

[Teodora Vermesan (:TeoVermesan)]

I forgot to mention that "Don't keep activities" from Developers options is enabled.

Comment 5

[Aaron Train [:aaronmt]]

I've never touched that setting whatsoever when I hit this.

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #4)
> I forgot to mention that "Don't keep activities" from Developers options is
> enabled.

E/GeckoConsole(12831): Error reading pref [app.geo.reportdata]: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/browser.js :: getPreferences :: line 1064"  data: no]

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #6)
> (In reply to Teodora Vermesan (:TeoVermesan) from comment #4)
> > I forgot to mention that "Don't keep activities" from Developers options is
> > enabled.
> 
> E/GeckoConsole(12831): Error reading pref [app.geo.reportdata]:
> [Exception... "Component returned failure code: 0x8000ffff
> (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult: "0x8000ffff
> (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
> chrome://browser/content/browser.js :: getPreferences :: line 1064"  data:
> no]

Brad - I thought this was an Integer pref. Looks like it's being read as a Char. Also, this error is caught in the code and should not be causing any problem.

Brad - I do think we should add this pref to mobile.js so we minimize the spew.

In any case, this "error" is not causing the bug.

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Can I find the regressionwindow-wanted using these steps or fill another bug?

Comment 9

[Aaron Train [:aaronmt]]

I'd like to ascertain how I hit the original issue without ever even touching any developer options and how this.selectedTab became null

Comment 10

[Kartikaya Gupta (email:[e-mail])]

(In reply to Aaron Train [:aaronmt] from comment #9)
> I'd like to ascertain how I hit the original issue without ever even
> touching any developer options and how this.selectedTab became null

the "don't keep activities" option forces activities to be destroyed when exited. This can happen even when the option isn't checked if android is under memory pressure. The option is just a way to force the behaviour more reliably. It's quite possible that your activity was destroyed and resulted in the issue you saw.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Using my steps I found the regression window:
mozilla central:
good build: 30-04-2013
bad build:  01-05-2013

pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dd0c611a0a27&tochange=02aa81c59df6.
The tinderbox inbound builds are missing since the issue is older than one month.

Comment 12

[Aaron Train [:aaronmt]]

Sounds like either bug 866150 or bug 865060?

As well, I have not hit this bug since filing.

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

Aaron, can you test with don't keep activities. If it doesn't reproduce then close as WFM

Comment 14

[Aaron Train [:aaronmt]]

This is 100% reproducible when enabling 'Don't keep activities' and then switching back to the browser.

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 17

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.