B2G RIL: Add on-off switch for Cell Broadcast functions

RESOLVED FIXED in Firefox 24, Firefox OS v1.1hd

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: vicamo, Assigned: vicamo)

Tracking

unspecified
mozilla24
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:leo+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
This is Gecko part work for bug 874796, user story for enable/disable Cell Broadcast.
(Assignee)

Comment 1

5 years ago
In latest update in bug 874796 comment 8, "All channels - emergency and non-emergency channels should be switched on/off with this single option as per agreement with Operator."

We'll introduce a new boolean, default false, Settings entry "ril.cellbroadcast.disabled" to turn off Cell Broadcast completely even with non-empty CBMI/CBMID/CBMIR/MMI ("ril.cellbroadcast.searchlist") settings.
(Assignee)

Updated

5 years ago
Assignee: nobody → vyang
blocking-b2g: --- → leo?
Blocking a blocker, marking it leo+ .
blocking-b2g: leo? → leo+
(Assignee)

Comment 3

5 years ago
Created attachment 759345 [details] [diff] [review]
m-c patch 1/2

Refactor setDebugEnabled to setInitialOptions.  We always need a way to pre-set some parameters to ril_work at the very beginning stage.  DEBUG flag and CLIENT_ID are two examples.  Another new parameter, Cell Broadcast Disabled, is going to be added in the second patch.
Attachment #759345 - Flags: review?(allstars.chh)
(Assignee)

Updated

5 years ago
Attachment #759345 - Attachment description: m-c patch → m-c patch 1/2
(Assignee)

Comment 4

5 years ago
Created attachment 759350 [details] [diff] [review]
m-c patch 2/2

Implement "ril.cellbroadcast.disabled" that works as both Settings and Preference.  This parameter suggests RIL to disable CB function as possible.  On failure to disable/enable CB, the preference will not be rolled back to its original value.
Attachment #759350 - Flags: review?(allstars.chh)
(Assignee)

Comment 5

5 years ago
Created attachment 759370 [details] [diff] [review]
b2g18 patch 1/2
(Assignee)

Comment 6

5 years ago
Created attachment 759371 [details] [diff] [review]
b2g18 patch 2/2
(Assignee)

Updated

5 years ago
Blocks: 879630
Comment on attachment 759350 [details] [diff] [review]
m-c patch 2/2

Review of attachment 759350 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1953,5 @@
>          let setting = JSON.parse(data);
>          this.handleSettingsChange(setting.key, setting.value, setting.message);
>          break;
> +      case kPrefenceChangedObserverTopic:
> +        if (data == kCellBroadcastDisabled) {

can we use === ?
Attachment #759350 - Flags: review?(allstars.chh) → review+
Attachment #759345 - Flags: review?(allstars.chh) → review+
(Assignee)

Comment 8

5 years ago
Created attachment 759641 [details] [diff] [review]
m-c patch 2/2: v2

1) address review comments
2) fix unable to deactivate CB when search list is completely empty.
Attachment #759641 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #759350 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/2fee4d3f4941
https://hg.mozilla.org/mozilla-central/rev/fb94126589a7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
https://hg.mozilla.org/releases/mozilla-b2g18/rev/077f6ed61541
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bb6c9375f53b
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-firefox22: --- → wontfix
status-firefox23: --- → wontfix
status-firefox24: --- → fixed

Updated

5 years ago
Flags: in-moztrap-
Hi Vicamo, why are you toggling on the preference rather than the setting?  The situation seems very similar, if not the same, as ril.radio.disabled but the solution is different.  Why is that?
Flags: needinfo?(vyang)
(Assignee)

Comment 14

5 years ago
(In reply to Michael Schwartz [:m4] from comment #13)
> Hi Vicamo, why are you toggling on the preference rather than the setting? 
> The situation seems very similar, if not the same, as ril.radio.disabled but
> the solution is different.  Why is that?

Because desktop Firefox may not have Settings correctly setup.  We map Settings entries to preferences whenever possible so that we may implement that same function on desktop some day.
Flags: needinfo?(vyang)
(Assignee)

Updated

4 years ago
Blocks: 1008501
You need to log in before you can comment on or make changes to this bug.