879671 - B2G RIL: Add on-off switch for Cell Broadcast functions

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

This is Gecko part work for bug 874796, user story for enable/disable Cell Broadcast.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

In latest update in bug 874796 comment 8, "All channels - emergency and non-emergency channels should be switched on/off with this single option as per agreement with Operator."

We'll introduce a new boolean, default false, Settings entry "ril.cellbroadcast.disabled" to turn off Cell Broadcast completely even with non-empty CBMI/CBMID/CBMIR/MMI ("ril.cellbroadcast.searchlist") settings.

Comment 2

[bhavana bajaj [:bajaj]]

Blocking a blocker, marking it leo+ .

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: m-c patch 1/2

Refactor setDebugEnabled to setInitialOptions.  We always need a way to pre-set some parameters to ril_work at the very beginning stage.  DEBUG flag and CLIENT_ID are two examples.  Another new parameter, Cell Broadcast Disabled, is going to be added in the second patch.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: m-c patch 2/2

Implement "ril.cellbroadcast.disabled" that works as both Settings and Preference.  This parameter suggests RIL to disable CB function as possible.  On failure to disable/enable CB, the preference will not be rolled back to its original value.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: b2g18 patch 1/2

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Attachment: b2g18 patch 2/2

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 759350 [details] [diff] [review]
m-c patch 2/2

Review of attachment 759350 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1953,5 @@
>          let setting = JSON.parse(data);
>          this.handleSettingsChange(setting.key, setting.value, setting.message);
>          break;
> +      case kPrefenceChangedObserverTopic:
> +        if (data == kCellBroadcastDisabled) {

can we use === ?

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Attachment: m-c patch 2/2: v2

1) address review comments
2) fix unable to deactivate CB when search list is completely empty.

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/2fee4d3f4941
https://hg.mozilla.org/projects/birch/rev/fb94126589a7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2fee4d3f4941
https://hg.mozilla.org/mozilla-central/rev/fb94126589a7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/077f6ed61541
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bb6c9375f53b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/077f6ed61541
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/bb6c9375f53b

Comment 13

[Michael Schwartz [:m4]]

Hi Vicamo, why are you toggling on the preference rather than the setting?  The situation seems very similar, if not the same, as ril.radio.disabled but the solution is different.  Why is that?

Comment 14

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Michael Schwartz [:m4] from comment #13)
> Hi Vicamo, why are you toggling on the preference rather than the setting? 
> The situation seems very similar, if not the same, as ril.radio.disabled but
> the solution is different.  Why is that?

Because desktop Firefox may not have Settings correctly setup.  We map Settings entries to preferences whenever possible so that we may implement that same function on desktop some day.