879708 - bottom-aligned text columns in new /new page are cut for locales

Status: RESOLVED WORKSFORME

(www.mozilla.org :: Pages & Content, defect, P4)

Description

[Pascal Chevrel:pascalc]

Attachment: scheenshot for French showing the bug

While working on the updated firefox/new page for locales, I noticed that the text instructions in columns are bottom aligned according to the height of text in English. For all locales with translations longer than Englishn, that means the text is cut in the middle (see screenshot).

https://www-dev.allizom.org/b/fr/firefox/new/#download-fx

Comment 1

[Chris More [:cmore]]

What Firefox version are you running? I am not seeing this on my Firefox 21.

Comment 2

[Chris More [:cmore]]

Attachment: Screenshots showing up on Firefox 21 french download page

Comment 3

[Pascal Chevrel:pascalc]

Firefox 21, and we are actually seeing different content because you are on mac

Comment 4

[Pascal Chevrel:pascalc]

note that the issue is not the screenshots but the text, your own screenshot doesn't show if the text is cut or not, can you check?

Comment 5

[Chris More [:cmore]]

Attachment: Text not getting cut on Firefox 21 on OSX.

Comment 6

[Chris More [:cmore]]

(In reply to Pascal Chevrel:pascalc from comment #3)
> Firefox 21, and we are actually seeing different content because you are on
> mac

That's right. You're on Linux. We should verify on Windows too.

Comment 7

[Pascal Chevrel:pascalc]

Actually, it looks like that I get the instructions for mac and windows merged and that would make the text twice the height. I don't have a windows machine to test, i'll ping people for that.

Comment 8

[Chris More [:cmore]]

Just an FYI for everyone. There are no screenshots for Linux on purpose because of all of the Linux flavors and the chances of Linux users not knowing how to install an app is slim.

Comment 9

[raymond [:retornam] (inactive)]

This is a Linux only bug. I am able to see the whole text in in Windows. I think we should increase the space between the bottom text and the footer a bit to fix this.

Comment 10

[Kohei Yoshino [:kohei]]

Attachment: screenshot on Windows 8

Comment 11

[Holly Habstritt Gaal [:Habber]]

+ 1 to Raymond's fix about adding spacing to bottom of text block to account for longer descriptions.

Comment 12

[Chris More [:cmore]]

(In reply to raymond [:retornam] from comment #9)
> This is a Linux only bug. I am able to see the whole text in in Windows. I
> think we should increase the space between the bottom text and the footer a
> bit to fix this.

Thanks Raymond. We should fix this, but it shouldn't be a blocker since Linux is 1.37% of our download traffic by OS type.

Comment 13

[Chris More [:cmore]]

Since we don't have Linux screenshots, we could just eliminate that space where the screenshots are at on Linux and that would probably solve the space issue. Probably would look better too.

Comment 14

[Jennifer Bertsch [:jbertsch]]

I agree, this is not a blocker.

Comment 15

[Alex Gibson [:agibson]]

Attachment: Screenshot of what linux users should be seeing

I'm unable to reproduce what's in Pascal's screenshot as I'm not on Linux. I've attached a image of what should be displayed for Linux users (I've taken this on OSX by changing change the html class name from `osx` to `linux`, so the applicable CSS selectors kick in).

Seems this bug might not be a CSS issue, but more to do with the wrong content being shown on the device?

Comment 16

[Alex Gibson [:agibson]]

Just to follow up - I've found a way to reproduce what's in Pascal's screenshot.

If I set the html class name to 'other', it shows exactly what pascal is seeing.

This means that in site.js, getPlatform() is returning `false` for 'navigator.platform.indexOf("Linux") !== -1'.

Pascal, can you provide what navigator.platform reads for you?

Comment 17

[Pascal Chevrel:pascalc]

It reads: Linux x86_64

Comment 18

[Alex Gibson [:agibson]]

What do you see added to the html class name in inspector?

Comment 19

[Pascal Chevrel:pascalc]

I just checked the page again in both fx22 and nightly and I am no longer seeing the bug.

Comment 20

[Alex Gibson [:agibson]]

Excellent! Glad you said that, otherwise I would have thought it would be impossible :)