Main thread input in URL classifier

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Yoric, Assigned: sankha)

Tracking

({main-thread-io})

unspecified
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=Yoric][lang=js][Async:P2][qa-])

Attachments

(1 attachment, 2 obsolete attachments)

URL classifier's PROT_UrlCryptoKeyManager.prototype.maybeLoadOldKey loads a file on the main thread.

Profile: http://people.mozilla.com/~bgirard/cleopatra/#report=c934a0182d38178331a2bbce35a62f6a190aad74&search=urlclassifierlib.js

It might be possible to load the file off main thread using OS.File
Summary: URL classifier's → Main thread input in URL classifier
Assignee: nobody → sankha93
Posted patch patch v1 (obsolete) — Splinter Review
Attachment #758523 - Flags: review?(dteller)
Comment on attachment 758523 [details] [diff] [review]
patch v1

Let's wait until the blocker is finished.
Attachment #758523 - Flags: review?(dteller)
Posted patch patch v2 (obsolete) — Splinter Review
Attachment #758523 - Attachment is obsolete: true
Attachment #827879 - Flags: review?(dteller)
Comment on attachment 827879 [details] [diff] [review]
patch v2

Review of attachment 827879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
r=me if it passes tests

::: toolkit/components/url-classifier/content/url-crypto-key-manager.js
@@ +368,3 @@
>      }
> +
> +    oldKey = (new G_Protocol4Parser).parse(oldKey);

Could you take the opportunity to replace |var| with |let|?
Attachment #827879 - Flags: review?(dteller) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b740d9971771
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [mentor=Yoric][lang=js][Async:P2] → [mentor=Yoric][lang=js][Async:P2][qa-]
You need to log in before you can comment on or make changes to this bug.