879724 - Main thread input in URL classifier

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

URL classifier's PROT_UrlCryptoKeyManager.prototype.maybeLoadOldKey loads a file on the main thread.

Profile: http://people.mozilla.com/~bgirard/cleopatra/#report=c934a0182d38178331a2bbce35a62f6a190aad74&search=urlclassifierlib.js

It might be possible to load the file off main thread using OS.File

Comment 1

[Sankha Narayan Guria [:sankha]]

Attachment: patch v1

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 758523 [details] [diff] [review]
patch v1

Let's wait until the blocker is finished.

Comment 3

[Sankha Narayan Guria [:sankha]]

Attachment: patch v2

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 827879 [details] [diff] [review]
patch v2

Review of attachment 827879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
r=me if it passes tests

::: toolkit/components/url-classifier/content/url-crypto-key-manager.js
@@ +368,3 @@
>      }
> +
> +    oldKey = (new G_Protocol4Parser).parse(oldKey);

Could you take the opportunity to replace |var| with |let|?

Comment 5

[Sankha Narayan Guria [:sankha]]

Attachment: patch v3

tbpl: https://tbpl.mozilla.org/?tree=Try&rev=d52462c31de5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b740d9971771

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b740d9971771