879773 - Lazy loading is not working well when STK async command is received

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

When an async STK command is received, settins will open the ICC page but lazy loading is not working if this load is made automatically instead manually by the user.

Now it shows a blank screen !

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Kaze suggest the last Lazy loading changes could be related to this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=857105
https://github.com/mozilla-b2g/gaia/pull/9991

It fails if the ICC page loading is made from this code:
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc_menu.js#L20

To force it, you can create a little (and dirty) hack like this:
https://github.com/frsela/gaia/commit/85241115f9a730e7d3b0a0484aea28ce27faa544

so after some time, async faked STK commands will be sent to settings, settings app will be opened and will enter through the failing code.

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

After bisecting, the last working commit is: c7f5c27137cc36f51c9da194292e1e5055675017

First commit failing: eb6417144696335108a7fb1700ff2cfb57d6bf45

https://github.com/mozilla-b2g/gaia/commit/eb6417144696335108a7fb1700ff2cfb57d6bf45

Asking needinfo to Rik since he implemented the patch.

Comment 3

[Noemí Freire (:noemi)]

Hi,

Assigned to Anthony since he better knows the changes performed in Bug 857105 that might cause this regression.

Thanks.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Regression, blocking.

Comment 5

[Anthony Ricaud (:rik)]

Sorry I broke this. I grepped for all usages of location.host. icc_menu.js and icc.js actually replace the whole location address.

Comment 6

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10344

Pointer to Github pull-request

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 761443 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10344

Fernando: Thanks a lot for the quick way to test this, this was really helpful!

Comment 8

[Anthony Ricaud (:rik)]

Commited on master: https://github.com/mozilla-b2g/gaia/compare/3c65d31e4e72...e3d191adfb54

Comment 9

[Anthony Ricaud (:rik)]

I'm confused with the leo+ status of this bug. The original bug was not uplifted to v1-train so there's no reason to uplift this one either.

If we do uplift the original one, I'll make sure that we uplift this one as well of course.

Comment 10

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Anthony Ricaud (:rik) from comment #9)
> I'm confused with the leo+ status of this bug. The original bug was not
> uplifted to v1-train so there's no reason to uplift this one either.
> 
> If we do uplift the original one, I'll make sure that we uplift this one as
> well of course.

You're right, v1-train didn't fail.

This bug broked master and affected de STK refactoring work which will go to leo. I suppose your first patch (with this) will go to leo too, but I don't know

Comment 11

[Anthony Ricaud (:rik)]

I had to commit a followup cause my patch broke the linter :(

https://github.com/mozilla-b2g/gaia/commit/81441427a3ee58410a70e79aec4a6fae40507c50

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 e3d191adfb54497524ddef31de2b6defc93bf4e7
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1-train
  git cherry-pick -x  81441427a3ee58410a70e79aec4a6fae40507c50
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[Anthony Ricaud (:rik)]

John: This bug doesn't require uplift yet. If bug 857105 gets leo+ed, we'll uplift it.

Comment 14

[Anthony Ricaud (:rik)]

Uplifted with bc9ee4e39fe3446c149c70cd2bc5f012df6b4e5f and fa16d3f57f46a8be5094c3675fe2f51df3e4a0fb

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: fa16d3f57f46a8be5094c3675fe2f51df3e4a0fb