879809 - MOZBUILD_BACKEND_CHECKED should be unset when processing external directories

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This push removed a file and deleted its corresponding moz.build entry. However, the build slaves were still looking for it.
https://hg.mozilla.org/integration/mozilla-inbound/rev/25ea966531ca

https://tbpl.mozilla.org/php/getParsedLog.php?id=23814634&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=23815235&tree=Mozilla-Inbound

Comment 1

[Gregory Szorc [:gps]]

It appears config.status didn't run for js/src despite a moz.build file changing. Most interesting.

Comment 2

[Gregory Szorc [:gps]]

The problem is that MOZBUILD_BACKEND_CHECKED (a global flag used to determine whether moz.build rebuild scan and possibly rebuild has been performed) is defined by the root Makefile and exported to the environment under which js/src executes. js/src should get a "fresh" environment not polluted with this variable.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Don't export MOZBUILD_BACKEND_CHECKED to independent build systems

This should do it. I wish this could be done with make syntax instead of
shell. However, SUBMAKE gets $(call)ed inside a recipe and thus its
output is evaluated as shell commands, not make. It's ugly.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 761737 [details] [diff] [review]
Don't export MOZBUILD_BACKEND_CHECKED to independent build systems

Review of attachment 761737 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/rules.mk
@@ +428,3 @@
>  +@$(UPDATE_TITLE)
> ++@if test -n "$(3)"; then \
> +  MOZBUILD_BACKEND_CHECKED= $(MAKE) $(if $(2),-C $(2)) $(1); \

So, you could write this as another make $(if), right?

+$(if $(3) MOZBUILD_BACKEND_CHECKED= ) $(MAKE) $(if $(2),-C $(2)) $(1)

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 761737 [details] [diff] [review]
Don't export MOZBUILD_BACKEND_CHECKED to independent build systems

Review of attachment 761737 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review till you consider my proposal.

Comment 6

[Gregory Szorc [:gps]]

Attachment: Don't export MOZBUILD_BACKEND_CHECKED to independent build systems

Switched to inline $(if) (I keep forgetting this exists).

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This needs to be fixed immediately.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 763691 [details] [diff] [review]
Don't export MOZBUILD_BACKEND_CHECKED to independent build systems

Review of attachment 763691 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if this doesn't break pymake.

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/169e58567f28

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/169e58567f28