879884 - Remove Lookup methods, Xpath elements from lib/downloads.js

Status: RESOLVED DUPLICATE of bug 908649

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Jonathan French (:jfrench)]

Split off from bug 503192, this is a marker bug to remove and replace all elementslib.Lookup methods and Xpath elements from lib/downloads.js, to support the upcoming Australis theme.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's not only for Australis but a good move in general. Lookup expressions are too fragile for any kind of ui change. So we have to replace those with ID, Selector, or if no other base class works with NodeCollector. As template you might want to use the getElements() method we already have in addons.js or toolbar.js.

Comment 2

[Jonathan French (:jfrench)]

And the getElements() method in lib/addons.js is here
http://hg.mozilla.org/qa/mozmill-tests/file/b8a22c8c9a3b/lib/addons.js#l1026

Comment 3

[Amod [:AMoz]]

I would like to work on this bug. I would upload the patch within a while.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Amod, thank you for your interest. I will assign this bug to you then. Please ask us if you need some more information.

Comment 5

[Amod [:AMoz]]

hi whimboo. Now I am heading towards Santa Clara for Mozilla Summit 2013. I will try to find time there. Else I would resume the work after returning.

Comment 6

[Amod [:AMoz]]

Sorry whimboo, Since I am busy with my academics, I wont be able to find time before March 2, 2014. If you feel that, it is too long to wait, you are free to assign it to someone more deserving. 
Thank you. Looking forward to work with you again after I return.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Amod for the update. Actually Andrei is working on a complete refactoring of the downloads module over on bug 908649.