Last Comment Bug 879954 - Implement OES_texture_float_linear
: Implement OES_texture_float_linear
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla24
Assigned To: Guillaume Abadie
:
Mentors:
Depends on: 879952
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-05 13:16 PDT by Benoit Jacob [:bjacob] (mostly away)
Modified: 2013-06-11 14:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch that have to be pull after patch 879952 (10.18 KB, patch)
2013-06-06 12:58 PDT, Guillaume Abadie
jacob.benoit.1: review-
Details | Diff | Review
patch for landing (12.20 KB, patch)
2013-06-07 08:32 PDT, Guillaume Abadie
no flags Details | Diff | Review
patch for final landing (12.31 KB, patch)
2013-06-07 11:00 PDT, Guillaume Abadie
jacob.benoit.1: review+
Details | Diff | Review

Description Benoit Jacob [:bjacob] (mostly away) 2013-06-05 13:16:43 PDT
Generally, implementing a WebGL extension is documented there:

  https://wiki.mozilla.org/Platform/GFX/WebGL/Contribute/Extensions

In this particular case however, it's going to be a lot quicker than the general case. Skip all the parts that are about the IDL and JavaScript bindings. In bug 879952, we disabled linear filtering of float textures. When the OES_texture_float_linear extension is re-enabled, we want to re-allow linear filtering of float textures.
Comment 1 Guillaume Abadie 2013-06-06 12:58:41 PDT
Created attachment 759366 [details] [diff] [review]
patch that have to be pull after patch 879952

Implement OES_texture_float_linear. Have to be pull after patch 879952.
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2013-06-06 19:41:00 PDT
Comment on attachment 759366 [details] [diff] [review]
patch that have to be pull after patch 879952

Review of attachment 759366 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.cpp
@@ +989,2 @@
>              return gl->IsExtensionSupported(gl->IsGLES2() ? GLContext::OES_texture_float
> +                                            : GLContext::ARB_texture_float);

Ah, no, wait, this requires a check for the separate _linear extension!

http://www.khronos.org/registry/gles/extensions/OES/OES_texture_float_linear.txt

::: content/canvas/src/WebGLExtensions.h
@@ +145,5 @@
> +{
> +public:
> +    WebGLExtensionTextureFloatLinear(WebGLContext*);
> +    virtual ~WebGLExtensionTextureFloatLinear();
> +    

Trailing whitespace.

::: content/canvas/src/WebGLTexture.cpp
@@ +332,5 @@
>          {
>              if (mMinFilter == LOCAL_GL_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_NEAREST)
>              {
>                  mContext->GenerateWarning("%s is a texture with a linear minification filter "
> +                                          "that is not compatible with gl.FLOAT. "

Note (yes, I know that this is from your previous patch): this is better phrased as:

"%s is a texture with a linear minification filter, "
"which is not compatible with gl.FLOAT by default."

@@ +333,5 @@
>              if (mMinFilter == LOCAL_GL_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_NEAREST)
>              {
>                  mContext->GenerateWarning("%s is a texture with a linear minification filter "
> +                                          "that is not compatible with gl.FLOAT. "
> +                                          "OES_texture_float_linear might be a solution if supported.", msg_rendering_as_black);

The new second sentence would be better phrased:

   Try enabling the OES_texture_float_linear extension if supported.
Comment 3 Guillaume Abadie 2013-06-07 08:32:51 PDT
Created attachment 759759 [details] [diff] [review]
patch for landing

have to be push after patch 879952
Comment 4 Guillaume Abadie 2013-06-07 11:00:31 PDT
Created attachment 759829 [details] [diff] [review]
patch for final landing
Comment 5 Benoit Jacob [:bjacob] (mostly away) 2013-06-10 13:50:12 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/dbf8cb7f9755
Comment 6 Ed Morley [:emorley] 2013-06-11 01:44:19 PDT
https://hg.mozilla.org/mozilla-central/rev/dbf8cb7f9755

Note You need to log in before you can comment on or make changes to this bug.