The default bug view has changed. See this FAQ.

Implement OES_texture_float_linear

RESOLVED FIXED in mozilla24

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: Guillaume Abadie)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Generally, implementing a WebGL extension is documented there:

  https://wiki.mozilla.org/Platform/GFX/WebGL/Contribute/Extensions

In this particular case however, it's going to be a lot quicker than the general case. Skip all the parts that are about the IDL and JavaScript bindings. In bug 879952, we disabled linear filtering of float textures. When the OES_texture_float_linear extension is re-enabled, we want to re-allow linear filtering of float textures.
(Assignee)

Comment 1

4 years ago
Created attachment 759366 [details] [diff] [review]
patch that have to be pull after patch 879952

Implement OES_texture_float_linear. Have to be pull after patch 879952.
Attachment #759366 - Flags: review?(bjacob)
(Reporter)

Comment 2

4 years ago
Comment on attachment 759366 [details] [diff] [review]
patch that have to be pull after patch 879952

Review of attachment 759366 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.cpp
@@ +989,2 @@
>              return gl->IsExtensionSupported(gl->IsGLES2() ? GLContext::OES_texture_float
> +                                            : GLContext::ARB_texture_float);

Ah, no, wait, this requires a check for the separate _linear extension!

http://www.khronos.org/registry/gles/extensions/OES/OES_texture_float_linear.txt

::: content/canvas/src/WebGLExtensions.h
@@ +145,5 @@
> +{
> +public:
> +    WebGLExtensionTextureFloatLinear(WebGLContext*);
> +    virtual ~WebGLExtensionTextureFloatLinear();
> +    

Trailing whitespace.

::: content/canvas/src/WebGLTexture.cpp
@@ +332,5 @@
>          {
>              if (mMinFilter == LOCAL_GL_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_NEAREST)
>              {
>                  mContext->GenerateWarning("%s is a texture with a linear minification filter "
> +                                          "that is not compatible with gl.FLOAT. "

Note (yes, I know that this is from your previous patch): this is better phrased as:

"%s is a texture with a linear minification filter, "
"which is not compatible with gl.FLOAT by default."

@@ +333,5 @@
>              if (mMinFilter == LOCAL_GL_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_LINEAR || mMinFilter == LOCAL_GL_LINEAR_MIPMAP_NEAREST)
>              {
>                  mContext->GenerateWarning("%s is a texture with a linear minification filter "
> +                                          "that is not compatible with gl.FLOAT. "
> +                                          "OES_texture_float_linear might be a solution if supported.", msg_rendering_as_black);

The new second sentence would be better phrased:

   Try enabling the OES_texture_float_linear extension if supported.
Attachment #759366 - Flags: review?(bjacob) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 759759 [details] [diff] [review]
patch for landing

have to be push after patch 879952
Attachment #759366 - Attachment is obsolete: true
Attachment #759759 - Flags: review?(bjacob)
(Assignee)

Comment 4

4 years ago
Created attachment 759829 [details] [diff] [review]
patch for final landing
Attachment #759759 - Attachment is obsolete: true
Attachment #759759 - Flags: review?(bjacob)
Attachment #759829 - Flags: review?(bjacob)
(Reporter)

Updated

4 years ago
Attachment #759829 - Flags: review?(bjacob) → review+
(Reporter)

Comment 5

4 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/dbf8cb7f9755
Target Milestone: --- → mozilla24
https://hg.mozilla.org/mozilla-central/rev/dbf8cb7f9755
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.